Added functionality for modifing graph metadata using UI#456
Open
Added functionality for modifing graph metadata using UI#456
Conversation
Collaborator
Author
|
Adding a dropdown to "Edit" button would help to notify users what content can be updated with the button (metadata). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated old PR #364
Fixes #317
Implemented UI for modifying user meta-data which includes the following
Gif of the implementation
Introduced Problem from original PR:
When all the tags are removed and an update is performed, Elastic search was not updating properly. The
map_attributesmethod wasn't returning the proper name for tags. It was returningtagswithout a data type becausetagswas an empty dictionary. In order for elasticSearch to update the tags, it must be in the format ofstring_tags, so we added a case inmap_attributesto append the data type totags:if (key == 'tags'): value_type = DataType.forValue("String")Thanks to @bruce-wayne99 for original PR fix