Refactor: Update Itinerary Service Tests

[matthewhjt]

CHANGES:

• Added Tests for create Itinerary when createdBlock is emptyList and when no default transport mode is given
• Added Tests for update Itinerary when createdSection is empty, createdBlock is empty, when route to next block doesn't exist
• Added tests for findMyCompletedItineraries when page is invalid
• Updated removeItinerary implementation so it doesn't check itinerary exists again
• Added tests for createContingencyPlan to handle route creation
• Added tests for updateContingencyPlan to handle edge cases in route creation

Summary by CodeRabbit

• Tests
  • Added test cases to cover edge scenarios in itinerary creation and update, including default transport mode usage and handling of missing or empty data.
• Chores
  • Simplified itinerary removal process by streamlining permission and existence checks.

[coderabbitai]

Walkthrough

The test suite for ItineraryService was extended with multiple new test cases focusing on route creation behavior during itinerary creation and update operations. For createItinerary, two new tests were added: one verifies that when a section has empty blocks and the routeToNext object lacks a transportMode, the service defaults to TRANSPORT_MODE.DRIVE for route creation; the other ensures no routes are created if a section from the DTO is not found in the created itinerary's sections. For updateItinerary, several tests were added to cover route deletion and creation logic: one confirms existing routes are deleted when blocks have routeToNext and new routes are created accordingly; others verify that route creation is skipped if the corresponding created section or block is missing; one test confirms route creation when the next block exists; another ensures the default transport mode is used if not provided; and one test verifies that route creation is skipped when the created block is undefined or null. Additionally, the removeItinerary method was simplified by removing a redundant existence check before deletion, relying solely on the update permission check to verify itinerary existence and ownership. No changes were made to exported or public entities.

Changes

File(s)	Change Summary
src/itinerary/itinerary.service.spec.ts	Added multiple new test cases for createItinerary and updateItinerary covering route creation defaults, deletion, and handling of missing or empty sections/blocks.
src/itinerary/itinerary.service.ts	Simplified removeItinerary method by removing explicit existence check before deletion; relies on permission check instead.

Poem

In the warren of tests, we burrow deep,
Covering edge cases while others sleep.
If a route’s mode is missing, we DRIVE along,
And missing sections? We hop right on.
With every test, the code feels bright—
A rabbit’s work keeps bugs from sight! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Lite

📥 Commits

Reviewing files that changed from the base of the PR and between 33f55c9 and aabf771.

📒 Files selected for processing (1)

• src/itinerary/itinerary.service.ts (0 hunks)

💤 Files with no reviewable changes (1)

• src/itinerary/itinerary.service.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

⚠️ Warning: PBI number not found in PR title. Skipping status update.

[github-actions]

🎯 Allure Test Report is Ready!
📊 View Report

[github-actions]

🎯 Allure Test Report is Ready!
📊 View Report

[github-actions]

🎯 Allure Test Report is Ready!
📊 View Report

[daffarafi]

Terima kasih, Matthew. Saya sudah memeriksa hasilnya di SonarQube, dan saya melihat bahwa semua test case sudah tercover dengan baik tanpa adanya isu baru yang muncul.

Menurut saya, semua aspek yang diperlukan sudah tercakup, dan tidak ada permasalahan yang teridentifikasi. Terima kasih atas kerjasamanya.