Migrate Notify.js CDN URL from RawGit to jsDelivr #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidord
force-pushed
the
fix/notifyjs-cdn
branch
from
7de32dc to
ff1056d
Compare
Collaborator
|
Merci a toi, je viens de push la 0.13.3 avec ton fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le service rawgit.com a récemment fermé : https://web.archive.org/web/20260104025439/https://rawgit.com/
L'URL suivante ne fonctionne plus : https://rawgit.com/notifyjs/notifyjs/master/dist/notify.js
Ceci provoque un crash de l'UI de MyElectricalData.
Ce PR propose de remplacer l'URL en question par jsDelivr.
J'ai cru comprendre que cette version de MyElectricalData n'était plus maintenue (cf #613 (comment)). Mais ici le correctif est vraiment trivial, ce serait dommage de ne pas le déployer.
Correctif testé sur mon instance personnelle (en 0.13.2), avec succès : plus de crash de l'UI.
Au besoin:
ghcr.io/bidord/myelectricaldata:0.13.2-fix-notifyjs-cdn