fixup! [FEATURE] Support for inserting an item in a CSSList

Author: ziegenberg

src/CSSList/CSSList.php

@@ -295,18 +295,17 @@ public function splice($iOffset, $iLength = null, $mReplacement = null)
     }
 
     /**
-     * Insert an item before its sibling.
+     * Inserts an item before its sibling.
      *
-     * @param RuleSet|CSSList|Import|Charset $oItem The item.
-     * @param RuleSet|CSSList|Import|Charset $oSibling The sibling.
+     * @param RuleSet|CSSList|Import|Charset $oItem
+     * @param RuleSet|CSSList|Import|Charset $oSibling
      */
     public function insertBefore($oItem, $oSibling): void
     {
-        $iIndex = in_array($oSibling, $this->aContents);
-        if ($iIndex === false) {
+        if (in_array($oSibling, $this->aContents, true) === false) {
             $this->append($oItem);
         } else {
-            $this->replace($oSibling, array($oItem, $oSibling));
+            $this->replace($oSibling, [$oItem, $oSibling]);
         }
     }
 

tests/CSSList/DocumentTest.php

@@ -87,9 +87,9 @@ public function setContentsReplacesContentsSetInPreviousCall(): void
     }
 
     /**
-     * @return \Generator<array<array<DeclarationBlock>, DeclarationBlock, DeclarationBlock, array<DeclarationBlock>>>
+     * @return array<string, array<string, DeclarationBlock|array<int, DeclarationBlock>>>
      */
-    public static function insertBeforeDataProvider(): \Generator
+    public static function insertContentBeforeInsertsContentBeforeSibblingOrAppendsIfSibblingNotFoundDataProvider(): array
     {
 
         $bogusOne = new DeclarationBlock();
@@ -106,32 +106,28 @@ public static function insertBeforeDataProvider(): \Generator
         $oOrphan = new DeclarationBlock();
         $oOrphan->setSelectors('.forever-alone');
 
-        yield 'insert before' => [
-            'initialContent' => [$bogusOne, $oSibling, $bogusTwo],
-            'oItem' => $oItem,
-            'oSibling' => $oSibling,
-            'expectedContent' => [$bogusOne, $oItem, $oSibling, $bogusTwo],
-            ];
-        yield 'append if not found' => [
-            'initialContent' => [$bogusOne, $oSibling, $bogusTwo],
-            'oItem' => $oItem,
-            'oSibling' => $oOrphan,
-            'expectedContent' => [$bogusOne, $oSibling, $bogusTwo, $oItem],
-            ];
+        return [
+            'insert before' => [
+                'initialContent' => [$bogusOne, $oSibling, $bogusTwo],
+                'oItem' => $oItem,
+                'oSibling' => $oSibling,
+                'expectedContent' => [$bogusOne, $oItem, $oSibling, $bogusTwo],
+            ],
+            'append if not found' => [
+                'initialContent' => [$bogusOne, $oSibling, $bogusTwo],
+                'oItem' => $oItem,
+                'oSibling' => $oOrphan,
+                'expectedContent' => [$bogusOne, $oSibling, $bogusTwo, $oItem],
+            ]
+        ];
     }
 
     /**
      * @test
      *
-     * @param $initialContent
-     * @param $oItem
-     * @param $oSibling
-     * @param $sPosition
-     * @param $expectedContent
-     *
      * @dataProvider insertBeforeDataProvider
      */
-    public function insertContentBefore(
+    public function insertContentBeforeInsertsContentBeforeSibblingOrAppendsIfSibblingNotFound(
         array $initialContent,
         DeclarationBlock $oItem,
         DeclarationBlock $oSibling,