Skip to content

[TASK] Deprecate passing Rule to RuleSet::getRules() #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

[TASK] Deprecate passing Rule to RuleSet::getRules() #1252

merged 2 commits into from
May 5, 2025

Conversation

@JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented May 4, 2025

And also getRulesAssoc().

Relates to #1247.

This is the backport of #1248.

@JakeQZ
[TASK] Deprecate passing Rule to RuleSet::getRules()
53b3148 
And also `getRulesAssoc()`.

Relates to #1247.

This is the backport of #1248.
@JakeQZ JakeQZ added cleanup deprecation A method, property, or some functionality has been deprecated. backport labels May 4, 2025
@JakeQZ JakeQZ requested a review from oliverklee May 4, 2025 23:36
@JakeQZ JakeQZ self-assigned this May 4, 2025
@JakeQZ
Copy link
Collaborator Author

JakeQZ commented May 4, 2025

There'll be a merge conflict in CHANGELOG.md with #1251, which might be resolvable with 'visual merge'.

@oliverklee oliverklee merged commit d11477c into v8.x May 5, 2025
11 checks passed
@oliverklee oliverklee deleted the backport/1248 branch May 5, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels

backport cleanup deprecation A method, property, or some functionality has been deprecated.

Projects

None yet

Milestone

8.9.0: Deprecations and bug fixes

Development

Successfully merging this pull request may close these issues.

3 participants

@JakeQZ @oliverklee