Skip to content

[CLEANUP] Streamline tests for getRules with matching pattern #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

[CLEANUP] Streamline tests for getRules with matching pattern #1282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 10 additions & 31 deletions tests/Unit/RuleSet/RuleSetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,42 +1001,21 @@ public function getRulesWithPatternReturnsAllMatchingRules(
array $matchingPropertyNames
): void {
$rulesToSet = self::createRulesFromPropertyNames($propertyNamesToSet);
$matchingRules = \array_filter(
$rulesToSet,
static function (Rule $rule) use ($matchingPropertyNames): bool {
return \in_array($rule->getRule(), $matchingPropertyNames, true);
}
// Use `array_values` to ensure canonical numeric array, since `array_filter` does not reindex.
$matchingRules = \array_values(
\array_filter(
$rulesToSet,
static function (Rule $rule) use ($matchingPropertyNames): bool {
return \in_array($rule->getRule(), $matchingPropertyNames, true);
}
)
);
$this->subject->setRules($rulesToSet);

$result = $this->subject->getRules($searchPattern);

foreach ($matchingRules as $expectedMatchingRule) {
self::assertContains($expectedMatchingRule, $result);
}
}

/**
* @test
*
* @param list<string> $propertyNamesToSet
* @param list<string> $matchingPropertyNames
*
* @dataProvider providePropertyNamesAndSearchPatternAndMatchingPropertyNames
*/
public function getRulesWithPatternFiltersNonMatchingRules(
array $propertyNamesToSet,
string $searchPattern,
array $matchingPropertyNames
): void {
$this->setRulesFromPropertyNames($propertyNamesToSet);

$result = $this->subject->getRules($searchPattern);

foreach ($result as $resultRule) {
// 'expected' and 'actual' are transposed here due to necessity
self::assertContains($resultRule->getRule(), $matchingPropertyNames);
}
// `Rule`s without pre-set positions are returned in the order set. This is tested separately.
self::assertSame($matchingRules, $result);
}

/**
Expand Down