This repository was archived by the owner on Feb 28, 2022. It is now read-only.
Check if cert files actually exist#36
Open
flatsiedatsie wants to merge 1 commit intoMycroftAI:masterfrom
Open
Conversation
Currently the code just checks if the variables have been set. If you followed the guide, this will be true. However, the cert files aren't actually at the location mentioned in the config file. This one-line change checks if the files actually exist. Optionally, the code could still be improved. If for some reason the user has specified a different cert files path than `./mycroft/personal_backend/certs/`, then this code is hard-wired to generate the files at that location anyway. It might be better to check which location the user has specified, and then try to generate the cert files at that location if they don't exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the code just checks if the variables have been set. If you followed the guide, this will be true. However, the cert files aren't actually at the location mentioned in the config file.
This one-line change checks if the files actually exist.
Optionally, the code could still be improved. If for some reason the user has specified a different cert files path than
./mycroft/personal_backend/certs/, then this code is hard-wired to generate the files at that location anyway. It might be better to check which location the user has specified, and then try to generate the cert files at that location if they don't exist.