Logic error fix #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonza10V
reviewed
Sep 23, 2025
| self.recovery_incubation = {'temperature': 37, 'hold_time_minutes': 60} | ||
| else: | ||
| self.recovery_incubation = recovery_incubation | ||
| self.recovery_incubation = recovery_incubation |
There was a problem hiding this comment.
This seems good to me I dont see the error, if there is no dict for recovery incubation it uses the default, if there is one added then that one is used insted.
the suggested fix removes that last bit and will make that it is always the one provided, that can be None causing a bug. See if these make sense to you and let me know your rationale.
Gonza10V
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed logic error where the self.recovery_incubation would be overwritten with input parameter even if not provided. Would result in self.recovery_incubation = None every time.