Test commit for PR

.buildkite/docs/knapsack-token-issue.md

@@ -0,0 +1,125 @@
+# Knapsack Pro: Why Same Token + Same Parallelism Breaks Test Filtering
+
+## The Issue
+
+When running separate test suites (e.g., unit tests and feature tests) with:
+- **Same** `KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC`
+- **Same** `parallelism` value
+- Same branch and commit
+
+Knapsack Pro treats all parallel jobs as **one unified test suite** and creates a shared queue.
+
+## How Knapsack Pro Queue/Split Works
+
+Knapsack Pro uses a cache key to identify unique test suite runs:
+
+```
+cache_key = (branch, commit_hash, node_total, api_token)
+```
+
+When this cache key is identical across different steps, Knapsack Pro assumes they are part of the **same test run** and distributes tests from a shared pool.
+
+## The Timeline of the Customer's Issue
+
+### Before Sep 26th (Working)
+```yaml
+# Unit tests
+parallelism: 8  # Different!
+token: SAME_TOKEN
+
+# Feature tests  
+parallelism: 6  # Different!
+token: SAME_TOKEN
+```
+
+Cache keys were **different** because `node_total` differed:
+- Unit: `(main, abc123, 8, token123)`
+- Feature: `(main, abc123, 6, token123)`
+
+### After Sep 26th (Broken)
+```yaml
+# Unit tests
+parallelism: 10  # Same!
+token: SAME_TOKEN
+
+# Feature tests
+parallelism: 10  # Same!
+token: SAME_TOKEN
+```
+
+Cache keys became **identical**:
+- Unit: `(main, abc123, 10, token123)`
+- Feature: `(main, abc123, 10, token123)`
+
+Both steps now share the same queue, and `KNAPSACK_PRO_TEST_FILE_PATTERN` is ignored at the API level.
+
+## The Fix
+
+**Use separate API tokens for each test suite:**
+
+```yaml
+steps:
+  - label: "Unit Tests"
+    parallelism: 10
+    env:
+      KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC: ${KNAPSACK_PRO_TOKEN_UNIT}
+      KNAPSACK_PRO_TEST_FILE_PATTERN: "spec/**/*_spec.rb"
+      KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN: "spec/features/**/*_spec.rb"
+    plugins:
+      - docker-compose#v5.x.x:
+          run: app
+          command: bundle exec rake knapsack_pro:queue:rspec
+          env:
+            - BUILDKITE_PARALLEL_JOB_COUNT
+            - BUILDKITE_PARALLEL_JOB
+            - KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC
+            - KNAPSACK_PRO_TEST_FILE_PATTERN
+            - KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN
+
+  - label: "Feature Tests"
+    parallelism: 10
+    env:
+      KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC: ${KNAPSACK_PRO_TOKEN_FEATURE}
+      KNAPSACK_PRO_TEST_FILE_PATTERN: "spec/features/**/*_spec.rb"
+    plugins:
+      - docker-compose#v5.x.x:
+          run: app
+          command: bundle exec rake knapsack_pro:queue:rspec
+          env:
+            - BUILDKITE_PARALLEL_JOB_COUNT
+            - BUILDKITE_PARALLEL_JOB
+            - KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC
+            - KNAPSACK_PRO_TEST_FILE_PATTERN
+```
+
+## How to Generate Additional Tokens
+
+1. Go to [Knapsack Pro Dashboard](https://knapsackpro.com/dashboard)
+2. Navigate to your organization → project
+3. Create a new test suite for "Feature Tests"
+4. Copy the new API token
+5. Add it to Buildkite as a secret environment variable
+
+## Key Documentation
+
+From [Knapsack Pro Reference](https://docs.knapsackpro.com/ruby/reference/):
+
+> **`KNAPSACK_PRO_TEST_SUITE_TOKEN_*`**
+> 
+> API token required to run Knapsack Pro.
+> **Each Knapsack Pro command defined on CI should use an individual API token.**
+
+## Additional Considerations
+
+When using the `docker-compose` plugin, ensure these env vars are passed to the container:
+
+```yaml
+env:
+  - BUILDKITE_PARALLEL_JOB_COUNT
+  - BUILDKITE_PARALLEL_JOB
+  - BUILDKITE_BUILD_NUMBER
+  - BUILDKITE_COMMIT
+  - BUILDKITE_BRANCH
+```
+
+Without these, Knapsack Pro inside the container won't know which parallel job it is.

.buildkite/hooks/environment

@@ -0,0 +1,4 @@
+#!/bin/bash
+
+export HOOK_VAR="set-in-environment-hook"
+export HOOK_SECRET="secret-from-hook"

.buildkite/knapsack-demo.yml

@@ -0,0 +1,111 @@
+# Demo pipeline to illustrate Knapsack Pro token behavior
+# This simulates what happens when two test steps share the same API token
+# with the same parallelism value
+
+env:
+  # Simulating a shared Knapsack Pro token (the problematic scenario)
+  SHARED_TOKEN: "same-token-for-both"
+
+steps:
+  - group: ":warning: PROBLEMATIC: Same token + Same parallelism"
+    steps:
+      - label: ":test_tube: Unit Tests (parallelism=2)"
+        parallelism: 2
+        command: |
+          echo "=== Unit Tests Step ==="
+          echo "BUILDKITE_PARALLEL_JOB_COUNT: $BUILDKITE_PARALLEL_JOB_COUNT"
+          echo "BUILDKITE_PARALLEL_JOB: $BUILDKITE_PARALLEL_JOB"
+          echo "KNAPSACK Token: $SHARED_TOKEN"
+          echo ""
+          echo "Knapsack Pro cache key would be:"
+          echo "  (branch=$BUILDKITE_BRANCH, commit=$BUILDKITE_COMMIT, nodes=$BUILDKITE_PARALLEL_JOB_COUNT)"
+          echo ""
+          echo "⚠️  With SAME token and SAME parallelism, both steps"
+          echo "   would share the SAME queue in Knapsack Pro API!"
+        env:
+          TEST_FILE_PATTERN: "spec/models/**/*_spec.rb"
+        agents:
+          queue: mac
+
+      - label: ":sparkles: Feature Tests (parallelism=2)"
+        parallelism: 2
+        command: |
+          echo "=== Feature Tests Step ==="
+          echo "BUILDKITE_PARALLEL_JOB_COUNT: $BUILDKITE_PARALLEL_JOB_COUNT"
+          echo "BUILDKITE_PARALLEL_JOB: $BUILDKITE_PARALLEL_JOB"
+          echo "KNAPSACK Token: $SHARED_TOKEN"
+          echo ""
+          echo "Knapsack Pro cache key would be:"
+          echo "  (branch=$BUILDKITE_BRANCH, commit=$BUILDKITE_COMMIT, nodes=$BUILDKITE_PARALLEL_JOB_COUNT)"
+          echo ""
+          echo "❌ This step might receive unit test files because"
+          echo "   it shares the same queue with Unit Tests step!"
+        env:
+          TEST_FILE_PATTERN: "spec/features/**/*_spec.rb"
+        agents:
+          queue: mac
+
+  - wait
+
+  - group: ":white_check_mark: CORRECT: Separate tokens"
+    steps:
+      - label: ":test_tube: Unit Tests (separate token)"
+        parallelism: 2
+        command: |
+          echo "=== Unit Tests Step ==="
+          echo "BUILDKITE_PARALLEL_JOB_COUNT: $BUILDKITE_PARALLEL_JOB_COUNT"
+          echo "BUILDKITE_PARALLEL_JOB: $BUILDKITE_PARALLEL_JOB"
+          echo "KNAPSACK Token: $UNIT_TEST_TOKEN"
+          echo ""
+          echo "✅ With SEPARATE token, this step has its OWN queue"
+          echo "   and will only receive unit test files."
+        env:
+          UNIT_TEST_TOKEN: "token-for-unit-tests"
+          TEST_FILE_PATTERN: "spec/models/**/*_spec.rb"
+        agents:
+          queue: mac
+
+      - label: ":sparkles: Feature Tests (separate token)"
+        parallelism: 2
+        command: |
+          echo "=== Feature Tests Step ==="
+          echo "BUILDKITE_PARALLEL_JOB_COUNT: $BUILDKITE_PARALLEL_JOB_COUNT"
+          echo "BUILDKITE_PARALLEL_JOB: $BUILDKITE_PARALLEL_JOB"
+          echo "KNAPSACK Token: $FEATURE_TEST_TOKEN"
+          echo ""
+          echo "✅ With SEPARATE token, this step has its OWN queue"
+          echo "   and will only receive feature test files."
+        env:
+          FEATURE_TEST_TOKEN: "token-for-feature-tests"
+          TEST_FILE_PATTERN: "spec/features/**/*_spec.rb"
+        agents:
+          queue: mac
+
+  - wait
+
+  - label: ":memo: Summary"
+    command: |
+      echo "=============================================="
+      echo "KNAPSACK PRO TOKEN BEHAVIOR SUMMARY"
+      echo "=============================================="
+      echo ""
+      echo "THE PROBLEM:"
+      echo "When two steps have:"
+      echo "  - Same API token"
+      echo "  - Same parallelism value"
+      echo "  - Same branch/commit"
+      echo ""
+      echo "Knapsack Pro sees them as ONE test suite and creates"
+      echo "a shared queue. Both steps pull from the same pool of"
+      echo "tests, ignoring TEST_FILE_PATTERN filtering."
+      echo ""
+      echo "THE FIX:"
+      echo "Use SEPARATE API tokens for each test suite:"
+      echo "  - KNAPSACK_PRO_TEST_SUITE_TOKEN_UNIT for unit tests"
+      echo "  - KNAPSACK_PRO_TEST_SUITE_TOKEN_FEATURE for feature tests"
+      echo ""
+      echo "Generate additional tokens at:"
+      echo "https://knapsackpro.com/dashboard"
+      echo "=============================================="
+    agents:
+      queue: mac

.buildkite/pipeline.yml

@@ -1,17 +1,59 @@
+env:
+  BUILDKITE_PLUGIN_S3_CACHE_BUCKET: "ola-buildkite-cache"
+
 steps:
-  - label: "Job with dynamic priorityy"
+  # ===== ARTIFACTS APPROACH =====
+  - label: ":package: Artifacts - Install (UV)"
+    agents:
+      queue: mac
     command: |
-      if [ "$BUILDKITE_RETRY_COUNT" -eq 0 ]; then
-        PRIORITY=1
-      else
-        PRIORITY=0
-      fi
-
-      buildkite-agent pipeline upload <<YAML
-      steps:
-        - label: "Actual work (priority \$PRIORITY)"
-          command: "echo 'Running tests'; exit 1"
-          priority: \$PRIORITY
-          retry:
-            automatic: true
-      YAML
+      uv venv .venv
+      source .venv/bin/activate
+      uv pip install -r requirements.txt
+      tar -czf venv.tar.gz .venv
+      buildkite-agent artifact upload venv.tar.gz
+
+  - wait
+
+  - label: ":white_check_mark: Artifacts - Use deps"
+    agents:
+      queue: mac
+    command: |
+      buildkite-agent artifact download venv.tar.gz .
+      tar -xzf venv.tar.gz
+      source .venv/bin/activate
+      pip list
+
+  - wait
+
+  # ===== CACHE PLUGIN APPROACH =====
+  - label: ":floppy_disk: Cache - Install (UV)"
+    agents:
+      queue: mac
+    plugins:
+      - cache#v1.8.1:
+          backend: s3
+          path: .venv-cached
+          manifest: requirements.txt
+          save: file
+          compression: tgz
+    command: |
+      uv venv .venv-cached
+      source .venv-cached/bin/activate
+      uv pip install -r requirements.txt
+
+  - wait
+
+  - label: ":white_check_mark: Cache - Use deps"
+    agents:
+      queue: mac
+    plugins:
+      - cache#v1.8.1:
+          backend: s3
+          path: .venv-cached
+          manifest: requirements.txt
+          restore: file
+          compression: tgz
+    command: |
+      source .venv-cached/bin/activate
+      pip list

.github/workflows/trigger-buildkite-on-sync.yml

@@ -3,22 +3,18 @@ name: Trigger Buildkite on PR Sync
 on:
   pull_request:
     types: [synchronize]
+  workflow_dispatch:
 
 jobs:
   trigger-buildkite:
     runs-on: ubuntu-latest
     steps:
-      - name: Trigger Buildkite Build
-        env:
-          BUILDKITE_API_TOKEN: ${{ secrets.BUILDKITE_API_TOKEN }}
-        run: |
-          curl -X POST "https://api.buildkite.com/v2/organizations/${{ vars.BUILDKITE_ORG_SLUG }}/pipelines/${{ vars.BUILDKITE_PIPELINE_SLUG }}/builds" \
-            -H "Authorization: Bearer $BUILDKITE_API_TOKEN" \
-            -H "Content-Type: application/json" \
-            -d '{
-              "commit": "${{ github.event.pull_request.head.sha }}",
-              "branch": "${{ github.event.pull_request.head.ref }}",
-              "message": "PR #${{ github.event.pull_request.number }} sync - triggered from GitHub Actions",
-              "pull_request_id": "${{ github.event.pull_request.number }}",
-              "pull_request_base_branch": "${{ github.event.pull_request.base.ref }}"
-            }'
+      - name: Trigger Buildkite Build (using pipeline_uuid)
+        uses: buildkite/trigger-pipeline-action@pipeline-uuid-support
+        with:
+          buildkite_api_access_token: ${{ secrets.BUILDKITE_API_TOKEN }}
+          pipeline_uuid: ${{ vars.BUILDKITE_PIPELINE_UUID }}
+          branch: ${{ github.head_ref || github.ref_name }}
+          commit: ${{ github.event.pull_request.head.sha || github.sha }}
+          message: ":github: Triggered via pipeline_uuid"
+          send_pull_request: true

README.md

@@ -36,3 +36,5 @@ This project demonstrates a simple CI/CD pipeline with build and verification sc
 The build process creates:
 - `build/build-info.txt` - Build metadata
 - `build/manifest.json` - Build manifest with status and version info
+# Test
+# Another test line

requirements.txt

@@ -0,0 +1 @@
+requests==2.31.0