Support external Sui networks in hashi-localnet CLI#407
Draft
0xsiddharthks wants to merge 1 commit intosiddharth/e2e-test-signetfrom
Draft
Support external Sui networks in hashi-localnet CLI#4070xsiddharthks wants to merge 1 commit intosiddharth/e2e-test-signetfrom
0xsiddharthks wants to merge 1 commit intosiddharth/e2e-test-signetfrom
Conversation
0xsiddharthks
force-pushed
the
siddharth/e2e-test-signet
branch
from
11d4b50 to
1fd688e
Compare
0xsiddharthks
force-pushed
the
siddharth/e2e-test-signet
branch
from
1fd688e to
6a287a8
Compare
0xsiddharthks
force-pushed
the
siddharth/e2e-test-devnet
branch
from
48e67e2 to
1fe3aad
Compare
Add --sui-network flag to connect to external Sui networks (devnet, testnet) instead of spawning a local one. Mirrors the existing external Bitcoin node pattern with SuiNetworkInfo trait + ExternalSuiNetwork. For external networks, the Move source is patched at publish time to allow non-validator registration and committee formation with equal weight, since test keys are not actual Sui validators.
0xsiddharthks
force-pushed
the
siddharth/e2e-test-devnet
branch
from
1fe3aad to
7694a42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--sui-network devnet|testnetflag tohashi-localnet start(mirrors the existing--bitcoin-networkpattern)SuiNetworkInfotrait +ExternalSuiNetworkstruct (same pattern asBitcoinNodeInfo+ExternalBitcoinNode)--sui-addresstest_start_reconfigentry function that accepts explicit member addresses with equal weightUsage
hashi-localnet start \ --sui-network devnet \ --sui-address 0x6e8b...1ebe \ --bitcoin-network signet \ --btc-rpc-url http://127.0.0.1:38332 \ --btc-rpc-user signetrpc \ --btc-rpc-pass signetrpcpass \ --btc-wallet mining \ -v