guardian: integrate rate limiting into withdrawal flow#423
Draft
0xsiddharthks wants to merge 4 commits intomainfrom
Draft
guardian: integrate rate limiting into withdrawal flow#4230xsiddharthks wants to merge 4 commits intomainfrom
0xsiddharthks wants to merge 4 commits intomainfrom
Conversation
Wire up the guardian gRPC client in hashi and call it during withdrawal processing to enforce rate limits before committing withdrawal transactions on-chain.
Add SignGuardianWithdrawalRequest proto endpoint so each validator independently reconstructs and BLS-signs the StandardWithdrawalRequest. The leader fans out to the committee and aggregates signatures before forwarding to the guardian, matching the pattern used by all other withdrawal signing steps. Move the guardian gate from Step 2 to Step 3 so the PendingWithdrawal exists on-chain and validators can reconstruct the request from it.
Add LimiterState to GetGuardianInfoResponse so hashi can read the guardian's current next_seq at startup. This ensures the seq counter survives node restarts and leader rotations without drifting.
Fetch the guardian's signing pubkey at startup alongside the seq counter. After each standard_withdrawal call, deserialize the response into GuardianSigned<StandardWithdrawalResponse> and verify the Ed25519 signature against the cached pubkey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire up the guardian as a rate limiter in the withdrawal flow. When configured, the leader calls the guardian before MPC signing — if rate-limited, retry with backoff; if approved, proceed as normal. Guardian is fully optional (no
guardian_endpoint= no change in behavior).Changes:
GuardianClientgRPC wrapper +guardian_endpointconfig fieldSignGuardianWithdrawalRequestproto endpoint for committee BLS signingprocess_unsigned_pending_withdrawal(Step 3, before MPC signing)LimiterState.next_seqat startupLimiterStatetoGetGuardianInfoResponseprotoGuardian BTC signatures are received but not used in the witness yet — that needs 2-of-2 taproot deposit addresses (follow-up).