Merged
Conversation
benr-ml
reviewed
Apr 10, 2026
| reason: "Message previously received but no valid response was produced" | ||
| .to_string(), | ||
| }); | ||
| // No cached response, but the incoming hash matches what we have |
Contributor
There was a problem hiding this comment.
nice catch! maybe let's rename things so it would be clear in the call site what is cached and what is stored persistently (we might have similar bugs elsewhere)
Contributor
Author
There was a problem hiding this comment.
Added a TODO for renaming fields. The only similar situation I can find now is handle_complain_request, but it looks already correct.
zhouwfang
force-pushed
the
zhoufang/iop-322-fix-key-rotation-stuck
branch
from
f7d7c46 to
309b056
Compare
bmwill
approved these changes
Apr 13, 2026
zhouwfang
force-pushed
the
zhoufang/iop-322-fix-key-rotation-stuck
branch
4 times, most recently
from
fa0ce7b to
1f425ff
Compare
zhouwfang
changed the base branch from
zhoufang/iop-288-add-startup-logging
to
main
zhouwfang
force-pushed
the
zhoufang/iop-322-fix-key-rotation-stuck
branch
from
1f425ff to
98a1b02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#95