feat: add multi key type support for enclave signatures#27
Draft
prateekreddy wants to merge 2 commits intoMystenLabs:mainfrom
Draft
feat: add multi key type support for enclave signatures#27prateekreddy wants to merge 2 commits intoMystenLabs:mainfrom
prateekreddy wants to merge 2 commits intoMystenLabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for multiple cryptographic key types (Ed25519, Secp256k1) in enclave signature verification to enable attestations with various public key types.
Changes:
KeyTypeenum with Ed25519 and Secp256k1 variantskey_typefield toEnclavestruct to track signature schemeregister_enclave_with_key_type()for explicit key type selectionregister_enclave()defaults to Ed25519register_enclave_ed25519(),register_enclave_secp256k1()verify_signature()to dispatch based on key type using matchregister_enclave.shto support optional key_type parameterNote: Enclave struct now includes
key_typefield. Existing enclaves will need to be re registered if upgraded.