Enhance ConnectButton with optional icons#500
Open
Emmanuelmelvin wants to merge 2 commits intoMystenLabs:mainfrom
Open
Enhance ConnectButton with optional icons#500Emmanuelmelvin wants to merge 2 commits intoMystenLabs:mainfrom
Emmanuelmelvin wants to merge 2 commits intoMystenLabs:mainfrom
Conversation
…tButton Allow consumers to pass custom React nodes to be rendered before or after the connect button text. This enables more flexible UI designs, such as adding wallet icons or status indicators alongside the button label.
…rectly Adds a unit test to ensure that optional iconBefore and iconAfter props are rendered in the ConnectButton, in addition to the connectText.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the
ConnectButtoncomponent by adding two new optional props:iconBeforeandiconAfter.These allow consumers to pass custom React nodes (e.g., wallet icons, status indicators) that render before or after the
connectTextlabel.Additionally, a new unit test was added to verify that
iconBeforeandiconAfterrender correctly alongside the button text.Test plan
@testing-library/reactto renderConnectButtonwithiconBeforeandiconAfterprops.connectText.