Skip to content

[seal] update default for verifyKeyServers to false #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyqvq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[seal] update default for verifyKeyServers to false #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaky-aliens-kiss.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@mysten/seal': minor
---

[seal] Update default for verifyKeyServers to false
2 changes: 1 addition & 1 deletion packages/seal/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class SealClient {
.map((server) => server.weight)
.reduce((sum, term) => sum + term, 0);

this.#verifyKeyServers = options.verifyKeyServers ?? true;
this.#verifyKeyServers = options.verifyKeyServers ?? false;
this.#timeout = options.timeout ?? 10_000;
}

Expand Down
12 changes: 10 additions & 2 deletions packages/seal/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ export type SealCompatibleClient = ClientWithExtensions<{
export interface SealOptions<Name = 'seal'> {
/** Array of key server configs consisting of objectId, weight, optional API key name and API key */
serverConfigs: KeyServerConfig[];
/** Whether to verify the key servers' authenticity. */
/**
* Whether to verify the key servers' authenticity.
* Note: /service verification is skipped for committee key servers (serverType === 'Committee')
* since their requests go through an aggregator.
*/
verifyKeyServers?: boolean;
/** Timeout in milliseconds for network requests. */
timeout?: number;
Expand All @@ -36,7 +40,11 @@ export interface SealClientOptions {
suiClient: SealCompatibleClient;
/** Array of key server configs consisting of objectId, weight, optional API key name and API key */
serverConfigs: KeyServerConfig[];
/** Whether to verify the key servers' authenticity. */
/**
* Whether to verify the key servers' authenticity.
* Note: /service verification is skipped for committee key servers (serverType === 'Committee')
* since their requests go through an aggregator.
*/
verifyKeyServers?: boolean;
/** Timeout in milliseconds for network requests. */
timeout?: number;
Expand Down
Loading