Fix: naming and exception messages cleanup#68
Open
niko-zvt wants to merge 3 commits intoMysticial:masterfrom
Open
Fix: naming and exception messages cleanup#68niko-zvt wants to merge 3 commits intoMysticial:masterfrom
niko-zvt wants to merge 3 commits intoMysticial:masterfrom
Conversation
…o 'handle_skip_warnings' in Launcher.cpp
Author
|
@Mysticial Hi! Thanks for the amazing y-crunch project - it’s truly impressive. I’ve submitted a small PR to help with some code adjustments. Hope it’s useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code quality and consistency improvements: naming fixes and correct function names in exception messages.
Changes
handles_skip_warnings→handle_skip_warningsto match other command handlers (handle_pause,handle_colors, etc.)."BaseFile::rename()"inFileExceptionmessages insideBaseFile::rename()instead of"RawFile::rename()"; add short comment explaining the choice.tostr_si_commaswithout +=instead ofreturn std::string("-") + ...to match file style.Testing