Cleanup libmythtv includes #1231
Merged
+161
−454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove unused m_parent class members.
hamm24* is now unused. chartab_original and unham84tab were never used.
It is only used by the V4LRecorders (although the information is just thrown away) and it extracts the data from a sampled analog waveform, so it is not relevant to the other caption/ files and unlikely to be reused except by a recorder.
CMake's mythconfig.h.in already sets these unconditionally to 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to make splitting libmythtv into several separate libraries easier.
However, the files in libmythtv are still too much of a bidirectional interconnected mesh to split at this time. I am thinking of splitting it into a libmythavplusplus, libmythio, libmythrecording, and libmythplayer.
Checklist