Skip to content

test: improve test coverage from 82% to 91%#2

Merged
N283T merged 1 commit intomainfrom
feature/improve-test-coverage
Feb 11, 2026
Merged

test: improve test coverage from 82% to 91%#2
N283T merged 1 commit intomainfrom
feature/improve-test-coverage

Conversation

@N283T
Copy link
Owner

@N283T N283T commented Feb 11, 2026

Summary

  • Add 22 new tests covering uncovered branches and error paths
  • converter.py: 84% → 96% (bond errors, conformer edge cases, stereo branches)
  • cli.py: 74% → 85% (output formats, error display, _generate_output)
  • sanitizer.py: 85% → 88% (max attempts, SMARTS null, non-valence problems)
  • Overall: 82% → 91%

Test plan

  • All 95 tests pass
  • ruff check/format clean
  • ty check passes
  • CI should pass (all checks green)

Add 22 new tests covering:
- _add_bonds error paths (KeyError, RuntimeError)
- _add_conformer edge cases (missing category, all-missing coords, degenerate)
- _assign_stereochemistry with MODEL-only conformer
- CLI unsupported format, SDF output, error display, _generate_output
- sanitizer max attempts exhaustion, SMARTS null, non-valence problems
@N283T N283T merged commit c9fd402 into main Feb 11, 2026
6 checks passed
@N283T N283T deleted the feature/improve-test-coverage branch February 11, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant