Open
Conversation
This adds a fixture for a corpus freqdist, which generates a warning (since django tries to load a fixture for something that is not a model). For now I'll leave this warning. But maybe we should fix this before merging this branch.
We were getting some errors when tests ran because the write operation didn't finish before trying to retrieve data.
The view will also be used to run the analyisis, but is not yet working for that.
This also includes a change to the corpus analysis fixture, to keep the data with the "user" user.
This is what the backend expects.
| {"index_name": doc.index_name, "doc_type": doc.doc_type}}) | ||
| (Extractor().si(doc_id) | ElasticIndexer().si(doc_id))() | ||
|
|
||
| def corpus_freqdist(corpus): |
There was a problem hiding this comment.
Shouldn't this have a verb-name, like calculate_corpus_freqdist? I thought the call on the view was strange because of this.
Member
Author
There was a problem hiding this comment.
Agreed. I just pushed that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the functionality in the frontend to use the functionality added in NAMD/pypln.backend#183 .
The first worker available calculates the freqdist for a worker.