Skip to content

133 Add dynamic memory mgmt callbacks to host descriptors#141

Merged
jeronstone merged 21 commits intomainfrom
133-mem-mgmt-callbacks
Mar 19, 2026
Merged

133 Add dynamic memory mgmt callbacks to host descriptors#141
jeronstone merged 21 commits intomainfrom
133-mem-mgmt-callbacks

Conversation

@jeronstone
Copy link
Contributor

Closes #133

@jeronstone jeronstone added this to the BSL v1.1.0 milestone Mar 17, 2026
@jeronstone jeronstone self-assigned this Mar 17, 2026
@jeronstone jeronstone requested a review from a team as a code owner March 17, 2026 14:17
@github-project-automation github-project-automation bot moved this to Todo in BSL Mar 17, 2026
@jeronstone jeronstone marked this pull request as draft March 17, 2026 14:25
@jeronstone jeronstone moved this from Todo to In Progress in BSL Mar 17, 2026
@jeronstone jeronstone marked this pull request as ready for review March 17, 2026 15:21
Copy link
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any value in segregating the four callbacks into a separate struct, have a full default replacement struct, and require in setter that they are all non-null? It might prevent an accidental "forgot to set one" situation by the BPA. But would not change the overall behavior.

@jeronstone
Copy link
Contributor Author

Is there any value in segregating the four callbacks into a separate struct, have a full default replacement struct, and require in setter that they are all non-null? It might prevent an accidental "forgot to set one" situation by the BPA. But would not change the overall behavior.

I think I agree, it will make it cleaner. It is probably very unlikely a user will want to use custom callbacks for some, and defaults for others (and if a user really needs to, they can just set it manually to do so). I will make that update this evening.

Copy link
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make minor updates later today before approval

@jeronstone jeronstone deployed to sonarcloud March 19, 2026 01:20 — with GitHub Actions Active
@sonarqubecloud
Copy link

@jeronstone jeronstone merged commit b481035 into main Mar 19, 2026
17 checks passed
@jeronstone jeronstone deleted the 133-mem-mgmt-callbacks branch March 19, 2026 01:25
@github-project-automation github-project-automation bot moved this from In Progress to Done in BSL Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Support memory management through callbacks

2 participants