Actions Page Rework + Versioning + Archiving#1892
Actions Page Rework + Versioning + Archiving#1892AaronPlave wants to merge 35 commits intodevelopfrom
Conversation
c62768f to
be26563
Compare
dandelany
left a comment
There was a problem hiding this comment.
UI notes from testing with @AaronPlave today:
- The action run logs have some weird formatting/collapse behavior if you log a line that contains BOTH text and a JSON object. Eg. logging
{a: b, ...}on its own looks fine, but if you logmyObject is {a: b, ...big nested object}the logs will have some funky formatting with a timestamp inserted halfway through:
- General UI thought was that the action run results page feels "too application-y" and "not enough like a report". We discussed combining things on to one report-style page, with sections in the following order: Errors, Results, Logs, Parameters (leaving off any that don't apply). I'll run this by @nat-sims before we totally commit to it.
be26563 to
54709c6
Compare
It should - we decided that archiving would be the primary action deletion method since hard deleting actions and action versions goes against the traceability requirements we have. If one of these truly needs to be deleted an admin can always go in and do it in the db. @dandelany |
…r uses of ConsoleLog to slot in custom message components.
…ser from running action with no unarchived versions
src/utilities/actions.ts
Outdated
| } | ||
|
|
||
| export function getActionRunDeepLink(workspaceId: number, runId: number, actionId?: number | null): string { | ||
| const baseUrl = getWorkspacesUrl(base, workspaceId); |
There was a problem hiding this comment.
This function has some logic for adding some parameters. Can we extend its functionality to take action logic?
There was a problem hiding this comment.
Actually, there's also a getActionsUrl that might be more appropriate. It might also need to be updated to account for the new routing for actions.
___REQUIRES_AERIE_PR___="1803"Corresponding backend branch NASA-AMMOS/plandev#1803. Closes #1778
This PR moves the actions page into the workspace and introduces action+action definition versioning and archiving.
Workflows to test:
TODO: