Allow external sources to have their derivation group changed#1779
Open
JosephVolosin wants to merge 1 commit intodevelopfrom
Open
Allow external sources to have their derivation group changed#1779JosephVolosin wants to merge 1 commit intodevelopfrom
JosephVolosin wants to merge 1 commit intodevelopfrom
Conversation
Mythicaeda
reviewed
Feb 9, 2026
Comment on lines
+57
to
+60
| - role: user | ||
| permission: | ||
| columns: [derivation_group_name] | ||
| filter: {} |
Contributor
There was a problem hiding this comment.
This permission should have the same filter as in delete, rather than letting any user with the user role change it. (The delete permission says that only the owner of the source OR the owner of the derivation group the source is in can modify the source)
400155b to
0e3c676
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Hasura metadata for
external_sourceto allowderivation_group_nameto be changed - allowing sources to have the derivation group they belong to changed after upload (previously, the group was locked in at the time of upload).The potential downside of this change is that moving a source out of a derivation group that is currently tied to a plan will not provide any notification to the user that a source they may expect to be part of the plan is not longer part of the plan because it's derivation group was changed. The UI PR attempts to alleviate this by providing the user a warning if they are changing a source from a derivation group that is currently used by any plan(s).
This change should help allow more flexibility with derivation groups. Currently the process to change a derivation group is to delete the source and re-upload it with the new derivation group name, this also includes dis-associating the original derivation group from all plans its tied to prior to deleting the source and then re-associating the group afterwards.
Verification
Via. Hasura and UI PR
Documentation
aerie-docsshould be updated to reflect this optionFuture work
N/A