Open
Conversation
- Update WorkspaceBindings to use new error
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
8390b04 to
ec20854
Compare
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
ec20854 to
b2a94e4
Compare
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
b2a94e4 to
daced4a
Compare
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
daced4a to
5ac618e
Compare
- Update Move and Copy to consistently use java.nio.Files instead of a mix of java.nio.Files and java.io.File - Update thrown exceptions list for accuracy
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
5ac618e to
99d8a25
Compare
- Will no longer include METADATA type files in response - Made RenderType in charge of the Aerie Metadata type for the backend, as that extension is expected to be fairly constant - Remove unneeded Optional wrapper from `listFiles` method
- No longer updates `lastEditedBy` when the metadata is updated (unless that field is missing)
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
99d8a25 to
b411532
Compare
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
7da6993 to
9c55197
Compare
Mythicaeda
requested review from
dandelany and
mattdailis
and removed request for
cartermak and
joswig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.aerieto.meta.seqdevlistContentsendpoint to hideMETADATA-type files by default, and to provide the contents of the metadata files if thewithMetadataflag is providedVerification
I'd like to add some tests that focus on the contents of the metadata files, and how they're reconstructed after deletion, as well as basic bindings tests for the endpoints.
Documentation
No docs are invalidated, but we should add documenting these new endpoints to writing docs for the other workspace server endpoints
Future work