feat: add extra property to collection and collection List #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate-geojson-pydantic update geojson-pydantic req
…ed to store metadata related to the collection
|
@sanzog03 this seems too hacky - grabbing the collection properties from the items/first item. is this a pattern that already exists in the codebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
Add the ability to add extra parameters to collection and collectionList. Hence, they can be used to store metadata and extra information about the collection.
How I did it
In the current implementation of TiPg, a schema table in represents the whole collection and the rows represent items.
Since there is no separate table to store the collection data, If we add any columns with prefix "collection_properties_", we use that as extra properties.
A dependency injection is added which handles the above mentioned case.
How you can test it
First ingest data with a column prefixing with "collection_properties_". Then, using the API docs, test if it shows up in the collection and collection list endpoints.
Related Issues