Conversation
amarouane-ABDELHAK
requested review from
anayeaye,
botanical,
ividito,
slesaad and
smohiudd
| AWS_REGION: ${{ inputs.aws-region }} | ||
| run: | | ||
| # Activate uv venv | ||
| source ../.venv/bin/activate |
There was a problem hiding this comment.
Does this venv already exist on the runner?
There was a problem hiding this comment.
Yes, it will be created during uv setup
There was a problem hiding this comment.
Cool. This uv stuff is new to me. Is there reason to deactivate at the end of the job in case another job follows on the same runner? Informational question only, not change request!
There was a problem hiding this comment.
It automatically deactivates when the step is complete. You'll need to manually activate it for the next step. It's an annoying thing of GitHub workflows but in this use case it actually turns out to be a useful feature, lol the irony.
There was a problem hiding this comment.
uv run make ... should also work here, but this is more explicit anyway
3 participants
Summary: Summary of changes
Run SM2A unit tests before deploying SM2A via veda-deploy
Changes
*Add running unit tests to terraform-deploy-sm2a