Skip to content

Remove complexity fixes, addressing issue 46#54

Merged
nlk36701 merged 1 commit intoNASymmetry:mainfrom
sgoodlett:sgoodlett
Jun 2, 2025
Merged

Remove complexity fixes, addressing issue 46#54
nlk36701 merged 1 commit intoNASymmetry:mainfrom
sgoodlett:sgoodlett

Conversation

@sgoodlett
Copy link
Collaborator

Fixing #46
Changed:

  • ProjectionOp:
    • Cleaned up some old commented code
  • Salc
    • Added attribute remove_complex that defaults to False and is set to True once finish_building(remove_complexity=True) is executed

@sgoodlett sgoodlett requested a review from nlk36701 June 2, 2025 13:22
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
molsym/salcs/salc.py 66.66% 1 Missing ⚠️
Flag Coverage Δ
unittests 75.56% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
molsym/salcs/projection_op.py 38.20% <ø> (ø)
molsym/salcs/salc.py 37.01% <66.66%> (-0.25%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@nlk36701 nlk36701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlk36701 nlk36701 merged commit c341103 into NASymmetry:main Jun 2, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants