Skip to content

Fix baseline_hist_locs set to None causing TypeError (#422) #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianpm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix baseline_hist_locs set to None causing TypeError (#422) #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
233f699
fix bug reported in #422
brianpm Feb 26, 2026
4c81c18
add generic environment yaml
brianpm Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions env/conda_environment_generic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: adf_v1.0.0
channels:
- conda-forge
- defaults
dependencies:
- python=3.12
- pyyaml=6.0.2
- scipy=1.12.0
- cartopy=0.23.0
- netcdf4=1.6.5
- xarray=2024.1.1
- uxarray=2025.03.0
- matplotlib=3.9.4
- pandas=2.2.0
- pint=0.23
- xskillscore=0.0.24
- geocat-comp=2024.04.0
- xesmf>=0.8.8
- nco
7 changes: 1 addition & 6 deletions lib/adf_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def __init__(self, config_file, debug=False):
# End if

# Check if history file path exists:
if any(baseline_hist_locs):
elif baseline_hist_locs and any(baseline_hist_locs):
#Check if user provided
if not baseline_hist_str:
baseline_hist_str = ['cam.h0a']
Expand All @@ -256,7 +256,6 @@ def __init__(self, config_file, debug=False):
base_hist_str = baseline_hist_str[0]
starting_location = Path(baseline_hist_locs)
print(f"\tChecking history files in '{starting_location}'")
file_list = sorted(starting_location.glob("*" + base_hist_str + ".*.nc"))

#Check if the history file location exists
if not starting_location.is_dir():
Expand Down Expand Up @@ -322,10 +321,6 @@ def __init__(self, config_file, debug=False):
print(msg)
eyear_baseline = base_found_eyr

#Grab baseline nickname
base_nickname = self.get_baseline_info('case_nickname')
if base_nickname is None:
base_nickname = data_name
#End if

#Grab baseline nickname
Expand Down