enable different time ranges for ts and climo files in LDF

[wwieder]

Description of changes:

LDF allows users to define seperate time bounds for climo vs. ts generation

All PRs Checklist:

@TeaganKing volunteered to functionally test this for me
Note, LDF will fail if there are multiple climo files for a variable in the same directory

It may be nice to use the same start year and end year for both ts and climo if users don't define climo_*_year strings. LDF already does this, but not sure how to enable it in CUPiD?

[wwieder]

One note, the config file used by LDF has the ability for users to add case_nickname for both test and base cases. This short name is then used in plots to avoid long strings in legend labels. I think I've done this correctly, but it would be nice to have a functional test.

Better yet may be to enable the code to just use the case_name if no case_nickname is provided in the config.yaml file, but for now I'm more interested in enabling / requiring users to provide a nickname

[TeaganKing]

I did also update external diag packages to use the nicknames and climo start/end years. Note that this IS backwards compatible if those are not included in the config file due to the default settings. Eg, if you don't provide a case nickname, the case nickname is set to the case name. If you don't provide climo start/end years, these are set to the start/end years. ADF config file generation script has also been updated to use these values if provided.

[TeaganKing]

Currently there is a line hist_str: clm2.h0 under both diag_cam_climo and diag_cam_baseline_climo. This does not match hist_str under diag_basic_info, and it doesn't seem to be pulled from the key metrics config file; rather, it's a default from the config file in LDF. We should probably write that one out from the config file, too. Also see #305

[TeaganKing]

The hist strings now work and LDF finds files & runs as expected. Note has been added to PR #305 . This has all been tested and looks good to me. @wwieder , can you make sure the changes I made work for you, and then, if so, I can merge this in?

[TeaganKing]

• @wwieder is still checking that regional plotting is working as expected

[TeaganKing]

Looks great to me! Once Will checks the output of regional plots, this can be merged in.

[wwieder]

My functional test of CUPiD failed @TeaganKing ... but I think this is because I didn't remove the offending line of code. I'll try getting to this later today or tomorrow.

 File "/glade/u/home/wwieder/CUPiD/externals/LDF/lib/../scripts/plotting/regional_climatology.py", line 88, in regional_climatology
    with open(ymlFilename, 'r') as file:
         ^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'lib/regions_lnd.yaml'

[TeaganKing]

Yes, I think you'll want to update that in LDF to do something similar to this line. Thanks for testing that!