Skip to content

Add additional regional time series#385

Open
dabail10 wants to merge 26 commits intoNCAR:mainfrom
dabail10:seaice
Open

Add additional regional time series#385
dabail10 wants to merge 26 commits intoNCAR:mainfrom
dabail10:seaice

Conversation

@dabail10
Copy link
Collaborator

@dabail10 dabail10 commented Jan 23, 2026

Description of changes:

  • Please add an explanation of what your changes do and why you'd like us to include them.
  • Adds Weddell and Ross Sea timeseries.
  • Rearranges some subpanels
  • Fixes some time axes
  • Add masking for contour plots

All PRs Checklist:

  • Have you followed the guidelines in our Contributor's Guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you made sure that the pre-commit checks passed (#8 in Adding Notebooks Guide)?
  • Have you successfully tested your changes locally when running standalone CUPiD?
  • Have you tested your changes as part of the CESM workflow?
  • Once you are ready to have your PR reviewed, have you changed it from a Draft PR to an Open PR?

New notebook PR Additional Checklist (if these do not apply, feel free to remove this section):

  • Have you hidden the code cells (#8 in Adding Notebooks Guide) in your notebook?
  • Have you removed any unused parameters from your cell tagged with parameters? These can cause confusing warnings that show up as DAG build with warnings.
  • Have you moved any observational data that you are using to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data and ensured that it follows this format within that directory: COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE?

@dabail10 dabail10 requested a review from mnlevy1981 January 23, 2026 20:32
@dabail10
Copy link
Collaborator Author

I would also like @duvivier to take a look.

@mnlevy1981 mnlevy1981 requested a review from duvivier February 4, 2026 21:34
@duvivier
Copy link
Collaborator

duvivier commented Feb 5, 2026

Three other general comments. Maybe not needed to merge this, but something we should change soon.

  1. I agree with @mnlevy1981 that bringing in SIC to the contour plots and masking them that way would probably be best overall. We can discuss if we mask at 15% or at 0.01%

  2. This isn't currently in the PR, but Dave can you fix the typo in the box/whisker plot labels that say Sea Ice Area when they're of sea ice volume? We can decide later if we want to change how we do the box plots as well.

  3. I do think at some point it would be nice to have different colormaps for different fields. We can work on this later though.

Otherwise I think this looks good

@dabail10 dabail10 changed the title Add Weddell Sea timeseries Add additional regional time series Feb 9, 2026
@dabail10
Copy link
Collaborator Author

dabail10 commented Feb 9, 2026

I have added the ice concentration > 0 as the mask for now in the contour and vector plots. I have also fixed the y-axis title in the box plots. I will work on color table stuff later.

https://webext.cgd.ucar.edu/BLT1850/b.e30_alpha07g.B1850C_LTso.ne30_t232_wgx3.287_ice/ice/html/infrastructure/index.html

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is ready for review or not... the key_metrics example ran fine, but when I ran the additional_metrics example the notebook raised an Exception:

- NotebookRunner: Hemis_seaice_visual_compare_contour -> File('computed_notebook...pare_contour.ipynb') -
- /glade/work/mlevy/codes/CUPiD.daveb/nblibrary/ice/Hemis_seaice_visual_compare_contour.ipynb -

---------------------------------------------------------------------------
Exception encountered at "In [8]":
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[8], line 16
14 mask1 = ds1["aice"].isel(time=slice(-climo_nyears * 12, None))
15 mask2 = ds2["aice"].isel(time=slice(-climo_nyears * 12, None))
---> 16 plot_diff(
17     field1,
18     field2,
19     levels,
20     case_name,
21     base_case_name,
22     title,
23     "N",
24     TLAT,
25     TLON,
26     mask1,
27     mask2,
28     path_HadleyOI,
29 )

TypeError: plot_diff() takes 10 positional arguments but 12 were given

@mnlevy1981
Copy link
Collaborator

mnlevy1981 commented Mar 11, 2026

Oh, I wonder if I need to rebuild cupid-utils since you updated the ice modules...

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, rebuilding cupid-utils let me run both notebooks. I don't see any red flags in the code diffs, and the notebook plots all look reasonable. @dabail10 if you're happy with the state of this branch, I'll hit "merge"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants