Conversation
…ing in the contour plots
|
I would also like @duvivier to take a look. |
|
Three other general comments. Maybe not needed to merge this, but something we should change soon.
Otherwise I think this looks good |
|
I have added the ice concentration > 0 as the mask for now in the contour and vector plots. I have also fixed the y-axis title in the box plots. I will work on color table stuff later. |
mnlevy1981
left a comment
There was a problem hiding this comment.
I'm not sure if this is ready for review or not... the key_metrics example ran fine, but when I ran the additional_metrics example the notebook raised an Exception:
- NotebookRunner: Hemis_seaice_visual_compare_contour -> File('computed_notebook...pare_contour.ipynb') -
- /glade/work/mlevy/codes/CUPiD.daveb/nblibrary/ice/Hemis_seaice_visual_compare_contour.ipynb -
---------------------------------------------------------------------------
Exception encountered at "In [8]":
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
Cell In[8], line 16
14 mask1 = ds1["aice"].isel(time=slice(-climo_nyears * 12, None))
15 mask2 = ds2["aice"].isel(time=slice(-climo_nyears * 12, None))
---> 16 plot_diff(
17 field1,
18 field2,
19 levels,
20 case_name,
21 base_case_name,
22 title,
23 "N",
24 TLAT,
25 TLON,
26 mask1,
27 mask2,
28 path_HadleyOI,
29 )
TypeError: plot_diff() takes 10 positional arguments but 12 were given|
Oh, I wonder if I need to rebuild |
mnlevy1981
left a comment
There was a problem hiding this comment.
Okay, rebuilding cupid-utils let me run both notebooks. I don't see any red flags in the code diffs, and the notebook plots all look reasonable. @dabail10 if you're happy with the state of this branch, I'll hit "merge"
Description of changes:
All PRs Checklist:
pre-commitchecks passed (#8 in Adding Notebooks Guide)?New notebook PR Additional Checklist (if these do not apply, feel free to remove this section):
parameters? These can cause confusing warnings that show up asDAG build with warnings./glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_dataand ensured that it follows this format within that directory:COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE?