Skip to content

Merging the changes/improvements from feature/release3.0.3#409

Open
byoung-joo wants to merge 87 commits intodevelopfrom
feature/release3.0.3_merging_develop
Open

Merging the changes/improvements from feature/release3.0.3#409
byoung-joo wants to merge 87 commits intodevelopfrom
feature/release3.0.3_merging_develop

Conversation

@byoung-joo
Copy link
Collaborator

@byoung-joo byoung-joo commented Dec 17, 2025

Work in progress

Description

This PR contains various updates from release/3.0.3 branch. Below you can find a brief summary of it.

  • Adding a set of new observation-related yaml files under config/jedi/ObsPlugs
    • It is worth to mention that now bufr-converted files will be used for MHS by default, rather than ncdiag-converted files.
  • Adding no outer loop update: true under background error, which initializes the B only one time. This fixes Skip the re-initialization of B #396.
  • The hybrid weights for static and ensemble B parts can be specified either from scalar values or from files. This can be controlled with variational.hybridBECWeightFromFile key, which has a default value as False. With this, config/jedi/applications/3dhybrid-allsky.yaml can be removed, which is essentially the same as config/jedi/applications/3dhybrid.yaml.
  • For the BUMP VertcalBalance, now the "global" vbal/sampling files will be used, instead of "local" files. There is no change in the result & runtime.
  • Adding new default meshes; 15 km and 15-3 km (many yamls under scenarios/defaults/ directory)
  • Adding the 30 km static B, 60 km LGETKF ensemble perturbation, 30 km LGETKF ensemble perturbation (see scenarios/defaults/variational.yaml)
  • Adding a set of scenarios, especially with a higher resolution or rttov-related ones.
  • While release/3.0.3 uses the crtm v2.4.x, this PR keeps the crtm v3 (as in current develop). Only updating the path for CRTMTABLES as /glade/campaign/mmm/parc/jban/pandac_common/crtm_coeffs_v3/, which also contains the coefficients files for active sensors.

junmeiban and others added 30 commits October 16, 2024 14:46
### Description

This PR updates data path for 30km externalanalyses for scenarios/3dhybrid-allsky_O30kmIE60km_SpecifiedEnsemble_VarBC.yaml .

Files modified:
scenarios/3dhybrid-allsky_O30kmIE60km_SpecifiedEnsemble_VarBC.yaml

### Tests completed
#### Tier 1:
 - [x] 3dhybrid-allsky_O30kmIE60km_SpecifiedEnsemble_VarBC
### Description
This PR adds changes for assimilating GNSSRO bending angle (ROPP1D and MetOffice operators) with the NRL observation error. Previous error parameters using the Desroziers et al 2005 method are commented out for reference. Here, the built code is also updated to account for recent changes in mpas-jedi to pass geometric height as geopotential height for bending angle forward simulations. 

In addition, the `ObsSpaceV2-to-V3.yaml` file and scenario `3denvar_O30kmIE60km_WarmStart.yaml` are updated.

### Tests completed
#### Tier 1:
 - [x] 3dvar_OIE120km_WarmStart
 - [x] 3denvar_OIE120km_IAU_WarmStart
 - [x] 3dvar_OIE120km_ColdStart
 - [x] 3dvar_O30kmIE60km_ColdStart
 - [x] 3denvar_O30kmIE60km_WarmStart
 - [x] eda_OIE120km_WarmStart
 - [x] getkf_OIE120km_WarmStart
 - [x] ForecastFromGFSAnalysesMPT

#### Tier 2:
 - [x] 3denvar_O30kmIE60km_WarmStart (under scenario folder)
…#333)

### Description
After looking at Jim's weekly results today I realized I forgot to remove configurations for my experiment with allsky AMSUA that I had added in my local branch. This branch should not include these changes at this point and therefore this PR accomplishes that. By having allsky AMSUA in the benchmark, results from develop will produce degradation/improvements in some regions (corresponding to improvements/degradation when adding these obs), as shown in Jim's results.

### Issue closed
None
predictor along with other predictors, for channels 8-10 and channel 13
#343)

This PR adds MHS clear-sky assimilation using raw observations to replace the ncdiag files.

- Use BennartzScatIndex check:
   References: Bennartz, R., A. Thoss, A. Dybbroe, and D. B. Michelson, 2002: Precipitation analysis using the 
  AdvancedMicrowave Sounding Unit in support of nowcasting applications. Meteorol. Appl., 9,177–189, 
  doi:10.1017/S1350482702002037.
- Assimilate MHS Channel 5 within the range of 60S to 60N degrees.
- Turn off MHS N19 Channel 3 due to poor quality.

- Modified files:
config/jedi/ObsPlugs/da/base/mhs_metop-a.yaml
config/jedi/ObsPlugs/da/base/mhs_metop-b.yaml
config/jedi/ObsPlugs/da/base/mhs_n18.yaml
config/jedi/ObsPlugs/da/base/mhs_n19.yaml
config/jedi/ObsPlugs/da/bias/mhs_metop-a.yaml
config/jedi/ObsPlugs/da/bias/mhs_metop-b.yaml
config/jedi/ObsPlugs/da/bias/mhs_n18.yaml
config/jedi/ObsPlugs/da/bias/mhs_n19.yaml
config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-a.yaml
config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-b.yaml
config/jedi/ObsPlugs/da/filtersWithBias/mhs_n18.yaml
config/jedi/ObsPlugs/da/filtersWithBias/mhs_n19.yaml
scenarios/3dhybrid_O30kmIE60km_SpecifiedEnsemble_VarBC.yaml
scenarios/defaults/observations.yaml

- Tests completed
 3dhybrid_O30kmIE60km (conducted month-long cycling DA)
 3denvar_OIE120km_WarmStart_VarBC (ran two cycles)
Description
Add 'reduce obs spcace' function to the thinning section to reduce memory usage.
With this function, those observations removed by thinning will not come to memory and will not be in the obsout_da files.
### Description

I realized that last week I accidentally merged local changes into this branch. The changes are related to ABI/AHI data assimilation then I don't think it affects anybody's runs so far but these changes are not ready to be in this branch yet. I rebased the branch by deleting that specific commit (262d045). I apologize for the confusion.
…s from default list in forecast post (#350)

## Description

Similar to PR [345](#345) to remove all jobs specification for the `forecast` entry in the scenario YAML files under the `scenarios` folder and `verifyobs` from the default list in the `post` for forecast. It also removes two scenarios: for abiahi and amsua, that were merged by mistake before.
### Description
Previous PR [348](#348) didn't work. Restoring abi/ahi settings and removing additional yamls here.
* Enforce usage of internal error table for prepbufr files

* Clean up specification of obs2ioda build
### Description
This PR is analogous to [PR#368](#368) to update the build path to support the new [obs2ioda_v3 ](https://github.com/NCAR/obs2ioda) code (by Andy Stokely) and modify the `ObsToIODA.csh` script to account for the same.

### Tests completed
#### Tier 2:
 - [x] GenerateObs
  with changes related to VarBC/Harnisch-error model and rttov14
	modified:   initialize/data/Observations.py
	modified:   initialize/framework/Build.py
	new file:   config/jedi/ObsPlugs/da/bias/amsua-cld_metop-a.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-cld_metop-b.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-cld_metop-c.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-cld_n15.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-cld_n18.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-cld_n19.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_metop-a.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_metop-b.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_metop-c.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_n15.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_n18.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_n19.yaml
	new file:   tools/update_analysis_states.py
dual-res. mesh
	new file:   scenarios/3denvar_O15kmI30km_AllSky.yaml
	new file:   scenarios/3denvar_O15kmI30km_SpecifiedEnsemble_VarBC.yaml
	new file:   scenarios/3dhybrid_O15-3kmI30km_SpecifiedEnsemble_VarBC.yaml
	new file:   scenarios/3dhybrid_O15-3kmI30km_SpecifiedEnsemble_VarBC_New.yaml
	new file:   scenarios/3dhybrid_O15kmI30km_SpecifiedEnsemble_VarBC.yaml
	new file:   scenarios/3dhybrid_O15kmI30km_SpecifiedEnsemble_VarBC_New.yaml
	new file:   scenarios/3dhybrid_O15kmI60km_SpecifiedEnsemble_VarBC_New.yaml
	new file:   scenarios/3dhybrid_OIE30km_SpecifiedEnsemble_VarBC.yaml
	new file:   scenarios/4dhybrid_O15kmI30km_SpecifiedEnsemble_VarBC_New.yaml
	new file:   scenarios/4dhybrid_O15kmI60km_SpecifiedEnsemble_VarBC_New.yaml
	new file:   scenarios/GenerateGFSAnalyses_15km.yaml
	new file:   scenarios/GenerateGFSAnalyses_15km3km.yaml
	modified:   config/jedi/ObsPlugs/enkf/ObsAnchors.yaml
	modified:   config/jedi/applications/3dhybrid-allsky.yaml
	modified:   config/jedi/applications/3dhybrid.yaml
	new file:   config/jedi/applications/3dhybrid_v3.yaml
	new file:   config/jedi/applications/4dhybrid_v3.yaml
	modified:   scenarios/defaults/enkf.yaml
	modified:   scenarios/defaults/externalanalyses.yaml
	modified:   scenarios/defaults/firstbackground.yaml
	modified:   scenarios/defaults/forecast.yaml
	modified:   scenarios/defaults/initic.yaml
	modified:   scenarios/defaults/model.yaml
	modified:   scenarios/defaults/variational.yaml
	modified:   bin/PrepJEDI.csh
	modified:   bin/Variational.csh # use 'mpiexec -N' instead of
'mpiexec'
	modified:   initialize/applications/Variational.py
	modified:   initialize/data/Model.py
	modified:   initialize/framework/HPC.py
scenarios/3dhybrid-allsky_O15kmI30km_SpecifiedEnsemble_VarBC_New.yaml
bin/PrepJEDI.csh
scenarios/defaults/variational.yaml
	modified:   bin/PrepJEDI.csh
	new file:   config/jedi/ObsPlugs/da/base/amsua-all_metop-a.yaml
	new file:   config/jedi/ObsPlugs/da/base/amsua-all_metop-b.yaml
	new file:   config/jedi/ObsPlugs/da/base/amsua-all_n15.yaml
	new file:   config/jedi/ObsPlugs/da/base/amsua-all_n18.yaml
	new file:   config/jedi/ObsPlugs/da/base/amsua-all_n19.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-all_metop-a.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-all_metop-b.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-all_n15.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-all_n18.yaml
	new file:   config/jedi/ObsPlugs/da/bias/amsua-all_n19.yaml
	new file:   config/jedi/ObsPlugs/da/filters/amsua-all_metop-a.yaml
	new file:   config/jedi/ObsPlugs/da/filters/amsua-all_metop-b.yaml
	new file:   config/jedi/ObsPlugs/da/filters/amsua-all_n15.yaml
	new file:   config/jedi/ObsPlugs/da/filters/amsua-all_n18.yaml
	new file:   config/jedi/ObsPlugs/da/filters/amsua-all_n19.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_metop-a.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_metop-b.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_n15.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_n18.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_n19.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_n19.yaml_cold-air-outbreak
	new file:   scenarios/1_3dhyb_asr-ama_csr-mhs.yaml
	modified:   scenarios/defaults/observations.yaml
	new file:   config/jedi/ObsPlugs/da/base/mhs-cld_metop-a.yaml
	new file:   config/jedi/ObsPlugs/da/base/mhs-cld_metop-b.yaml
	new file:   config/jedi/ObsPlugs/da/base/mhs-cld_n18.yaml
	new file:   config/jedi/ObsPlugs/da/base/mhs-cld_n19.yaml
	new file:   config/jedi/ObsPlugs/da/bias/mhs-cld_metop-a.yaml
	new file:   config/jedi/ObsPlugs/da/bias/mhs-cld_metop-b.yaml
	new file:   config/jedi/ObsPlugs/da/bias/mhs-cld_n18.yaml
	new file:   config/jedi/ObsPlugs/da/bias/mhs-cld_n19.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/mhs-cld_metop-a.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/mhs-cld_metop-b.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/mhs-cld_n18.yaml
	new file:   config/jedi/ObsPlugs/da/filtersWithBias/mhs-cld_n19.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-a.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-b.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/mhs_n18.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/mhs_n19.yaml
	new file:   scenarios/2_3dhyb_asr-ama_asr-mhs.yaml
	modified:   scenarios/defaults/observations.yaml
@byoung-joo
Copy link
Collaborator Author

Thanks, @junmeiban.

@byoung-joo
Copy link
Collaborator Author

This PR is almost ready for review.
@juhyejuhye will push some rttov-related modification to this branch.

juhyejuhye and others added 2 commits December 22, 2025 12:14
…nges in the develop branch

1. Remove "get values:" in rttov yamal files in base directory
2. Change variable name from " brightness_temperature_jacobian_surface_temperature" to " brightness_temperature_jacobian_skin_temperature_at_surface" in rttov yamal files in filtersWithBias directory

 On branch feature/release3.0.3_merging_develop
 Changes to be committed:
	modified:   config/jedi/ObsPlugs/da/base/amsua_aqua_rttov.yaml
 	modified:   config/jedi/ObsPlugs/da/base/amsua_metop-a_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua_metop-b_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua_n15_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua_n18_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua_n19_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs_metop-a_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs_metop-b_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs_n18_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs_n19_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/amsua_aqua_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/amsua_metop-a_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/amsua_metop-b_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/amsua_n15_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/amsua_n18_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/amsua_n19_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-a_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-b_rttov.yaml
 	modified:   config/jedi/ObsPlugs/da/filtersWithBias/mhs_n18_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/filtersWithBias/mhs_n19_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua-all_metop-a.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua-all_metop-b.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua-all_n15.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua-all_n18.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua-all_n19.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua-cld_metop-c.yaml
	modified:   config/jedi/ObsPlugs/da/base/amsua_n18_rttov12.yaml
	modified:   config/jedi/ObsPlugs/da/base/atms_n20.yaml
	modified:   config/jedi/ObsPlugs/da/base/atms_n21.yaml
	modified:   config/jedi/ObsPlugs/da/base/atms_npp.yaml
	modified:   config/jedi/ObsPlugs/da/base/cris-fsr_n20.yaml
	modified:   config/jedi/ObsPlugs/da/base/cris-fsr_n21.yaml
	modified:   config/jedi/ObsPlugs/da/base/cris-fsr_npp.yaml
	modified:   config/jedi/ObsPlugs/da/base/cris_n20.yaml
	modified:   config/jedi/ObsPlugs/da/base/cris_npp.yaml
	modified:   config/jedi/ObsPlugs/da/base/iasi_metop-a.yaml_66ch
	modified:   config/jedi/ObsPlugs/da/base/iasi_metop-a.yaml_88ch
	modified:   config/jedi/ObsPlugs/da/base/iasi_metop-a_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/iasi_metop-b.yaml_66ch
	modified:   config/jedi/ObsPlugs/da/base/iasi_metop-b.yaml_88ch
	modified:   config/jedi/ObsPlugs/da/base/iasi_metop-b_rttov.yaml
	modified:   config/jedi/ObsPlugs/da/base/iasi_metop-c.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs-cld_metop-a.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs-cld_metop-b.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs-cld_metop-c.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs-cld_n18.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs-cld_n19.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs_metop-c.yaml
	modified:   config/jedi/ObsPlugs/da/base/mhs_n18_rttov12.yaml
	modified:   config/jedi/ObsPlugs/hofx/base/cris-fsr_n20.yaml
	modified:   config/jedi/ObsPlugs/hofx/base/cris-fsr_n21.yaml
	modified:   config/jedi/ObsPlugs/hofx/base/cris-fsr_npp.yaml
	modified:   config/jedi/ObsPlugs/hofx/base/cris_n20.yaml
	modified:   config/jedi/ObsPlugs/hofx/base/cris_npp.yaml
	modified:   config/jedi/ObsPlugs/hofx/base/mhs_metop-c.yaml
@byoung-joo byoung-joo changed the title [draft] merging the changes/improvements in feature/release3.0.3 Merging the changes/improvements from feature/release3.0.3 Jan 7, 2026
@byoung-joo byoung-joo marked this pull request as ready for review January 7, 2026 20:13
@byoung-joo
Copy link
Collaborator Author

Hi all, this PR is ready for review.
This is rather a big change, but mostly for obs-related yaml files.
Please take your time to review the introduced changes.

Copy link
Collaborator

@juhyejuhye juhyejuhye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Thank you!

@junmeiban
Copy link
Collaborator

Hi @byoung-joo ,
The baseSeconds for scenario 1 and 2 are too big. I am testing it. I will give you a proper time setting after my test of it.

@byoung-joo
Copy link
Collaborator Author

The baseSeconds for scenario 1 and 2 are too big. I am testing it. I will give you a proper time setting after my test of it.

Thanks for noticing that. I have not checked the detailed configuration of experimental scenarios. It is much appreciated!!!

@junmeiban
Copy link
Collaborator

So far scenario 1 failed with the following error:

Exception: Error: YAML validation failed.
  Location:      /obsdataout
  Invalid value: {"engine":{"obsfile":"/glade/derecho/scratch/jban/pandac/jban_1_3dhyb_asrama_csrmhs/CyclingDA/2018041500/dbOut/obsout_da_aircraft.h5","type":"H5File"},"write multiple files":true}
  Cause:         additional properties are not allowed ('write multiple files' was unexpected)
Exception: oops::Variational<MPAS, UFO and IODA observations> terminating...

@junmeiban
Copy link
Collaborator

Same as your test, scenario 0 passed.

@byoung-joo
Copy link
Collaborator Author

Junmei and I confirmed that we need to specify the build directory accordingly.

@junmeiban
Copy link
Collaborator

The baseSeconds for scenario 1 and 2 are too big. I am testing it. I will give you a proper time setting after my test of it.

Thanks for noticing that. I have not checked the detailed configuration of experimental scenarios. It is much appreciated!!!

My suggest baseSeconds setting for scenario 1 and 2 :

          baseSeconds: 1500

@junmeiban
Copy link
Collaborator

The baseSeconds setting had a large value prior to this PR (https://github.com/JCSDA-internal/oops/pull/3010
; https://github.com/JCSDA-internal/mpas-jedi/issues/1082#issuecomment-3118991220
). However, my original setting was not adjusted after the PR was merged.

	modified:   1_3dhyb_asrama_csrmhs.yaml
	modified:   2_3dhyb_asrama_asrmhs.yaml
@byoung-joo
Copy link
Collaborator Author

@junmeiban,
The last commit 073392c addresses your suggestion!

@junmeiban
Copy link
Collaborator

@junmeiban, The last commit 073392c addresses your suggestion!

@byoung-joo, Many thanks for the commit. I am testing scenario 3.

@byoung-joo byoung-joo mentioned this pull request Jan 20, 2026
12 tasks
Comment on lines +347 to +348
atms_n20: /glade/derecho/scratch/liuz/pandac_common/obsiodav3_intScanP_20230927/2018/raw_obs
atms_npp: /glade/derecho/scratch/liuz/pandac_common/obsiodav3_intScanP_20230927/2018/raw_obs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byoung-joo , I updated ATMS obs with epoch time format for 2018 experiments, located in our campaign storage.
atms_n20: /glade/campaign/mmm/parc/jban/pandac/obsiodav3_intScanP_20230927/2018/raw_obs/2018051418
atms_npp: /glade/campaign/mmm/parc/jban/pandac/obsiodav3_intScanP_20230927/2018/raw_obs/2018051418

Comment on lines +399 to +400
atms_n20: /glade/derecho/scratch/liuz/pandac_common/obsiodav3_intScanP_20230927/2018/raw_obs
atms_npp: /glade/derecho/scratch/liuz/pandac_common/obsiodav3_intScanP_20230927/2018/raw_obs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines also need to be updated as follows:
atms_n20: /glade/campaign/mmm/parc/jban/pandac/obsiodav3_intScanP_20230927/2018/raw_obs/2018051418
atms_npp: /glade/campaign/mmm/parc/jban/pandac/obsiodav3_intScanP_20230927/2018/raw_obs/2018051418


a: [ 0.030, 0.030, 0.030, 0.020, 0.030,
0.005, 0.002, 0.001, 0.000, 0.000,
0.000, 0.000, 0.000, 0.000, 0.000,
Copy link
Collaborator

@junmeiban junmeiban Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 0.000 with 0.001 to prevent failure of the assertion ASSERT(abs(a[i]) > 0.0) in the code (https://github.com/JCSDA-internal/ufo/blob/9590d56355fa34be292d69f38c2cdb806681c760/src/ufo/filters/obsfunctions/ObsErrorModelQuad.cc#L67). This modification does not alter the results. For ch9 and ch10, fixed observation errors are used for err0 and err1. See my modified version: /glade/derecho/scratch/jban/MPAS-Workflow

Comment on lines +335 to +336
0.005, 0.002, 0.001, 0.000, 0.000,
0.000, 0.000, 0.000, 0.000, 0.000,
Copy link
Collaborator

@junmeiban junmeiban Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here. Replace 0.000 with 0.001

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same applies to atms_npp and atms_n21. See: /glade/derecho/scratch/jban/MPAS-Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip the re-initialization of B

10 participants