Merging the changes/improvements from feature/release3.0.3#409
Merging the changes/improvements from feature/release3.0.3#409byoung-joo wants to merge 87 commits intodevelopfrom
feature/release3.0.3#409Conversation
### Description This PR updates data path for 30km externalanalyses for scenarios/3dhybrid-allsky_O30kmIE60km_SpecifiedEnsemble_VarBC.yaml . Files modified: scenarios/3dhybrid-allsky_O30kmIE60km_SpecifiedEnsemble_VarBC.yaml ### Tests completed #### Tier 1: - [x] 3dhybrid-allsky_O30kmIE60km_SpecifiedEnsemble_VarBC
CMakeLists for new build
### Description This PR adds changes for assimilating GNSSRO bending angle (ROPP1D and MetOffice operators) with the NRL observation error. Previous error parameters using the Desroziers et al 2005 method are commented out for reference. Here, the built code is also updated to account for recent changes in mpas-jedi to pass geometric height as geopotential height for bending angle forward simulations. In addition, the `ObsSpaceV2-to-V3.yaml` file and scenario `3denvar_O30kmIE60km_WarmStart.yaml` are updated. ### Tests completed #### Tier 1: - [x] 3dvar_OIE120km_WarmStart - [x] 3denvar_OIE120km_IAU_WarmStart - [x] 3dvar_OIE120km_ColdStart - [x] 3dvar_O30kmIE60km_ColdStart - [x] 3denvar_O30kmIE60km_WarmStart - [x] eda_OIE120km_WarmStart - [x] getkf_OIE120km_WarmStart - [x] ForecastFromGFSAnalysesMPT #### Tier 2: - [x] 3denvar_O30kmIE60km_WarmStart (under scenario folder)
3dhybrid scenario
…#333) ### Description After looking at Jim's weekly results today I realized I forgot to remove configurations for my experiment with allsky AMSUA that I had added in my local branch. This branch should not include these changes at this point and therefore this PR accomplishes that. By having allsky AMSUA in the benchmark, results from develop will produce degradation/improvements in some regions (corresponding to improvements/degradation when adding these obs), as shown in Jim's results. ### Issue closed None
predictor along with other predictors, for channels 8-10 and channel 13
#343) This PR adds MHS clear-sky assimilation using raw observations to replace the ncdiag files. - Use BennartzScatIndex check: References: Bennartz, R., A. Thoss, A. Dybbroe, and D. B. Michelson, 2002: Precipitation analysis using the AdvancedMicrowave Sounding Unit in support of nowcasting applications. Meteorol. Appl., 9,177–189, doi:10.1017/S1350482702002037. - Assimilate MHS Channel 5 within the range of 60S to 60N degrees. - Turn off MHS N19 Channel 3 due to poor quality. - Modified files: config/jedi/ObsPlugs/da/base/mhs_metop-a.yaml config/jedi/ObsPlugs/da/base/mhs_metop-b.yaml config/jedi/ObsPlugs/da/base/mhs_n18.yaml config/jedi/ObsPlugs/da/base/mhs_n19.yaml config/jedi/ObsPlugs/da/bias/mhs_metop-a.yaml config/jedi/ObsPlugs/da/bias/mhs_metop-b.yaml config/jedi/ObsPlugs/da/bias/mhs_n18.yaml config/jedi/ObsPlugs/da/bias/mhs_n19.yaml config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-a.yaml config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-b.yaml config/jedi/ObsPlugs/da/filtersWithBias/mhs_n18.yaml config/jedi/ObsPlugs/da/filtersWithBias/mhs_n19.yaml scenarios/3dhybrid_O30kmIE60km_SpecifiedEnsemble_VarBC.yaml scenarios/defaults/observations.yaml - Tests completed 3dhybrid_O30kmIE60km (conducted month-long cycling DA) 3denvar_OIE120km_WarmStart_VarBC (ran two cycles)
Description Add 'reduce obs spcace' function to the thinning section to reduce memory usage. With this function, those observations removed by thinning will not come to memory and will not be in the obsout_da files.
### Description I realized that last week I accidentally merged local changes into this branch. The changes are related to ABI/AHI data assimilation then I don't think it affects anybody's runs so far but these changes are not ready to be in this branch yet. I rebased the branch by deleting that specific commit (262d045). I apologize for the confusion.
…s from default list in forecast post (#350) ## Description Similar to PR [345](#345) to remove all jobs specification for the `forecast` entry in the scenario YAML files under the `scenarios` folder and `verifyobs` from the default list in the `post` for forecast. It also removes two scenarios: for abiahi and amsua, that were merged by mistake before.
### Description Previous PR [348](#348) didn't work. Restoring abi/ahi settings and removing additional yamls here.
* Enforce usage of internal error table for prepbufr files * Clean up specification of obs2ioda build
### Description This PR is analogous to [PR#368](#368) to update the build path to support the new [obs2ioda_v3 ](https://github.com/NCAR/obs2ioda) code (by Andy Stokely) and modify the `ObsToIODA.csh` script to account for the same. ### Tests completed #### Tier 2: - [x] GenerateObs
with changes related to VarBC/Harnisch-error model and rttov14 modified: initialize/data/Observations.py modified: initialize/framework/Build.py
new file: config/jedi/ObsPlugs/da/bias/amsua-cld_metop-a.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-cld_metop-b.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-cld_metop-c.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-cld_n15.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-cld_n18.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-cld_n19.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_metop-a.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_metop-b.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_metop-c.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_n15.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_n18.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-cld_n19.yaml
new file: tools/update_analysis_states.py
dual-res. mesh new file: scenarios/3denvar_O15kmI30km_AllSky.yaml new file: scenarios/3denvar_O15kmI30km_SpecifiedEnsemble_VarBC.yaml new file: scenarios/3dhybrid_O15-3kmI30km_SpecifiedEnsemble_VarBC.yaml new file: scenarios/3dhybrid_O15-3kmI30km_SpecifiedEnsemble_VarBC_New.yaml new file: scenarios/3dhybrid_O15kmI30km_SpecifiedEnsemble_VarBC.yaml new file: scenarios/3dhybrid_O15kmI30km_SpecifiedEnsemble_VarBC_New.yaml new file: scenarios/3dhybrid_O15kmI60km_SpecifiedEnsemble_VarBC_New.yaml new file: scenarios/3dhybrid_OIE30km_SpecifiedEnsemble_VarBC.yaml new file: scenarios/4dhybrid_O15kmI30km_SpecifiedEnsemble_VarBC_New.yaml new file: scenarios/4dhybrid_O15kmI60km_SpecifiedEnsemble_VarBC_New.yaml new file: scenarios/GenerateGFSAnalyses_15km.yaml new file: scenarios/GenerateGFSAnalyses_15km3km.yaml
modified: config/jedi/ObsPlugs/enkf/ObsAnchors.yaml modified: config/jedi/applications/3dhybrid-allsky.yaml modified: config/jedi/applications/3dhybrid.yaml new file: config/jedi/applications/3dhybrid_v3.yaml new file: config/jedi/applications/4dhybrid_v3.yaml
modified: scenarios/defaults/enkf.yaml modified: scenarios/defaults/externalanalyses.yaml modified: scenarios/defaults/firstbackground.yaml modified: scenarios/defaults/forecast.yaml modified: scenarios/defaults/initic.yaml modified: scenarios/defaults/model.yaml modified: scenarios/defaults/variational.yaml
modified: bin/PrepJEDI.csh modified: bin/Variational.csh # use 'mpiexec -N' instead of 'mpiexec'
modified: initialize/applications/Variational.py modified: initialize/data/Model.py modified: initialize/framework/HPC.py
scenarios/3dhybrid-allsky_O15kmI30km_SpecifiedEnsemble_VarBC_New.yaml bin/PrepJEDI.csh scenarios/defaults/variational.yaml
modified: bin/PrepJEDI.csh new file: config/jedi/ObsPlugs/da/base/amsua-all_metop-a.yaml new file: config/jedi/ObsPlugs/da/base/amsua-all_metop-b.yaml new file: config/jedi/ObsPlugs/da/base/amsua-all_n15.yaml new file: config/jedi/ObsPlugs/da/base/amsua-all_n18.yaml new file: config/jedi/ObsPlugs/da/base/amsua-all_n19.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-all_metop-a.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-all_metop-b.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-all_n15.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-all_n18.yaml new file: config/jedi/ObsPlugs/da/bias/amsua-all_n19.yaml new file: config/jedi/ObsPlugs/da/filters/amsua-all_metop-a.yaml new file: config/jedi/ObsPlugs/da/filters/amsua-all_metop-b.yaml new file: config/jedi/ObsPlugs/da/filters/amsua-all_n15.yaml new file: config/jedi/ObsPlugs/da/filters/amsua-all_n18.yaml new file: config/jedi/ObsPlugs/da/filters/amsua-all_n19.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_metop-a.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_metop-b.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_n15.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_n18.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_n19.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/amsua-all_n19.yaml_cold-air-outbreak new file: scenarios/1_3dhyb_asr-ama_csr-mhs.yaml modified: scenarios/defaults/observations.yaml
new file: config/jedi/ObsPlugs/da/base/mhs-cld_metop-a.yaml new file: config/jedi/ObsPlugs/da/base/mhs-cld_metop-b.yaml new file: config/jedi/ObsPlugs/da/base/mhs-cld_n18.yaml new file: config/jedi/ObsPlugs/da/base/mhs-cld_n19.yaml new file: config/jedi/ObsPlugs/da/bias/mhs-cld_metop-a.yaml new file: config/jedi/ObsPlugs/da/bias/mhs-cld_metop-b.yaml new file: config/jedi/ObsPlugs/da/bias/mhs-cld_n18.yaml new file: config/jedi/ObsPlugs/da/bias/mhs-cld_n19.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/mhs-cld_metop-a.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/mhs-cld_metop-b.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/mhs-cld_n18.yaml new file: config/jedi/ObsPlugs/da/filtersWithBias/mhs-cld_n19.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-a.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-b.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/mhs_n18.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/mhs_n19.yaml new file: scenarios/2_3dhyb_asr-ama_asr-mhs.yaml modified: scenarios/defaults/observations.yaml
|
Thanks, @junmeiban. |
|
This PR is almost ready for review. |
…nges in the develop branch 1. Remove "get values:" in rttov yamal files in base directory 2. Change variable name from " brightness_temperature_jacobian_surface_temperature" to " brightness_temperature_jacobian_skin_temperature_at_surface" in rttov yamal files in filtersWithBias directory On branch feature/release3.0.3_merging_develop Changes to be committed: modified: config/jedi/ObsPlugs/da/base/amsua_aqua_rttov.yaml modified: config/jedi/ObsPlugs/da/base/amsua_metop-a_rttov.yaml modified: config/jedi/ObsPlugs/da/base/amsua_metop-b_rttov.yaml modified: config/jedi/ObsPlugs/da/base/amsua_n15_rttov.yaml modified: config/jedi/ObsPlugs/da/base/amsua_n18_rttov.yaml modified: config/jedi/ObsPlugs/da/base/amsua_n19_rttov.yaml modified: config/jedi/ObsPlugs/da/base/mhs_metop-a_rttov.yaml modified: config/jedi/ObsPlugs/da/base/mhs_metop-b_rttov.yaml modified: config/jedi/ObsPlugs/da/base/mhs_n18_rttov.yaml modified: config/jedi/ObsPlugs/da/base/mhs_n19_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/amsua_aqua_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/amsua_metop-a_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/amsua_metop-b_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/amsua_n15_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/amsua_n18_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/amsua_n19_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-a_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/mhs_metop-b_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/mhs_n18_rttov.yaml modified: config/jedi/ObsPlugs/da/filtersWithBias/mhs_n19_rttov.yaml
modified: config/jedi/ObsPlugs/da/base/amsua-all_metop-a.yaml modified: config/jedi/ObsPlugs/da/base/amsua-all_metop-b.yaml modified: config/jedi/ObsPlugs/da/base/amsua-all_n15.yaml modified: config/jedi/ObsPlugs/da/base/amsua-all_n18.yaml modified: config/jedi/ObsPlugs/da/base/amsua-all_n19.yaml modified: config/jedi/ObsPlugs/da/base/amsua-cld_metop-c.yaml modified: config/jedi/ObsPlugs/da/base/amsua_n18_rttov12.yaml modified: config/jedi/ObsPlugs/da/base/atms_n20.yaml modified: config/jedi/ObsPlugs/da/base/atms_n21.yaml modified: config/jedi/ObsPlugs/da/base/atms_npp.yaml modified: config/jedi/ObsPlugs/da/base/cris-fsr_n20.yaml modified: config/jedi/ObsPlugs/da/base/cris-fsr_n21.yaml modified: config/jedi/ObsPlugs/da/base/cris-fsr_npp.yaml modified: config/jedi/ObsPlugs/da/base/cris_n20.yaml modified: config/jedi/ObsPlugs/da/base/cris_npp.yaml modified: config/jedi/ObsPlugs/da/base/iasi_metop-a.yaml_66ch modified: config/jedi/ObsPlugs/da/base/iasi_metop-a.yaml_88ch modified: config/jedi/ObsPlugs/da/base/iasi_metop-a_rttov.yaml modified: config/jedi/ObsPlugs/da/base/iasi_metop-b.yaml_66ch modified: config/jedi/ObsPlugs/da/base/iasi_metop-b.yaml_88ch modified: config/jedi/ObsPlugs/da/base/iasi_metop-b_rttov.yaml modified: config/jedi/ObsPlugs/da/base/iasi_metop-c.yaml modified: config/jedi/ObsPlugs/da/base/mhs-cld_metop-a.yaml modified: config/jedi/ObsPlugs/da/base/mhs-cld_metop-b.yaml modified: config/jedi/ObsPlugs/da/base/mhs-cld_metop-c.yaml modified: config/jedi/ObsPlugs/da/base/mhs-cld_n18.yaml modified: config/jedi/ObsPlugs/da/base/mhs-cld_n19.yaml modified: config/jedi/ObsPlugs/da/base/mhs_metop-c.yaml modified: config/jedi/ObsPlugs/da/base/mhs_n18_rttov12.yaml modified: config/jedi/ObsPlugs/hofx/base/cris-fsr_n20.yaml modified: config/jedi/ObsPlugs/hofx/base/cris-fsr_n21.yaml modified: config/jedi/ObsPlugs/hofx/base/cris-fsr_npp.yaml modified: config/jedi/ObsPlugs/hofx/base/cris_n20.yaml modified: config/jedi/ObsPlugs/hofx/base/cris_npp.yaml modified: config/jedi/ObsPlugs/hofx/base/mhs_metop-c.yaml
feature/release3.0.3feature/release3.0.3
|
Hi all, this PR is ready for review. |
juhyejuhye
left a comment
There was a problem hiding this comment.
Look good! Thank you!
|
Hi @byoung-joo , |
Thanks for noticing that. I have not checked the detailed configuration of experimental scenarios. It is much appreciated!!! |
|
So far scenario 1 failed with the following error: |
|
Same as your test, scenario 0 passed. |
|
Junmei and I confirmed that we need to specify the build directory accordingly. |
My suggest |
|
The baseSeconds setting had a large value prior to this PR (https://github.com/JCSDA-internal/oops/pull/3010 |
modified: 1_3dhyb_asrama_csrmhs.yaml modified: 2_3dhyb_asrama_asrmhs.yaml
|
@junmeiban, |
@byoung-joo, Many thanks for the commit. I am testing scenario 3. |
| atms_n20: /glade/derecho/scratch/liuz/pandac_common/obsiodav3_intScanP_20230927/2018/raw_obs | ||
| atms_npp: /glade/derecho/scratch/liuz/pandac_common/obsiodav3_intScanP_20230927/2018/raw_obs |
There was a problem hiding this comment.
@byoung-joo , I updated ATMS obs with epoch time format for 2018 experiments, located in our campaign storage.
atms_n20: /glade/campaign/mmm/parc/jban/pandac/obsiodav3_intScanP_20230927/2018/raw_obs/2018051418
atms_npp: /glade/campaign/mmm/parc/jban/pandac/obsiodav3_intScanP_20230927/2018/raw_obs/2018051418
| atms_n20: /glade/derecho/scratch/liuz/pandac_common/obsiodav3_intScanP_20230927/2018/raw_obs | ||
| atms_npp: /glade/derecho/scratch/liuz/pandac_common/obsiodav3_intScanP_20230927/2018/raw_obs |
There was a problem hiding this comment.
These two lines also need to be updated as follows:
atms_n20: /glade/campaign/mmm/parc/jban/pandac/obsiodav3_intScanP_20230927/2018/raw_obs/2018051418
atms_npp: /glade/campaign/mmm/parc/jban/pandac/obsiodav3_intScanP_20230927/2018/raw_obs/2018051418
|
|
||
| a: [ 0.030, 0.030, 0.030, 0.020, 0.030, | ||
| 0.005, 0.002, 0.001, 0.000, 0.000, | ||
| 0.000, 0.000, 0.000, 0.000, 0.000, |
There was a problem hiding this comment.
Replace 0.000 with 0.001 to prevent failure of the assertion ASSERT(abs(a[i]) > 0.0) in the code (https://github.com/JCSDA-internal/ufo/blob/9590d56355fa34be292d69f38c2cdb806681c760/src/ufo/filters/obsfunctions/ObsErrorModelQuad.cc#L67). This modification does not alter the results. For ch9 and ch10, fixed observation errors are used for err0 and err1. See my modified version: /glade/derecho/scratch/jban/MPAS-Workflow
| 0.005, 0.002, 0.001, 0.000, 0.000, | ||
| 0.000, 0.000, 0.000, 0.000, 0.000, |
There was a problem hiding this comment.
Same thing here. Replace 0.000 with 0.001
There was a problem hiding this comment.
The same applies to atms_npp and atms_n21. See: /glade/derecho/scratch/jban/MPAS-Workflow
Work in progress
Description
This PR contains various updates from
release/3.0.3branch. Below you can find a brief summary of it.config/jedi/ObsPlugsno outer loop update: trueunderbackground error, which initializes the B only one time. This fixes Skip the re-initialization of B #396.variational.hybridBECWeightFromFilekey, which has a default value asFalse. With this,config/jedi/applications/3dhybrid-allsky.yamlcan be removed, which is essentially the same asconfig/jedi/applications/3dhybrid.yaml.scenarios/defaults/directory)scenarios/defaults/variational.yaml)release/3.0.3uses the crtm v2.4.x, this PR keeps the crtm v3 (as in currentdevelop). Only updating the path forCRTMTABLESas/glade/campaign/mmm/parc/jban/pandac_common/crtm_coeffs_v3/, which also contains the coefficients files for active sensors.