Skip to content

Rosenbrock DAE Constraint Count #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
davidfillmore wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Rosenbrock DAE Constraint Count #880

davidfillmore wants to merge 12 commits into from

Conversation

@davidfillmore
Copy link
Collaborator

@davidfillmore davidfillmore commented Nov 25, 2025 •
edited
Loading

  • Implemented builder-level support for future constraints without changing current behavior: added constraint count/name setters and used them to size Jacobian/state vectors and extend variable names, while carrying the count into StateParameters (include/micm/solver/solver_builder.hpp, include/micm/solver/solver_builder.inl). State now honors the provided constraint count when building identity masks and Jacobian dimensions (include/micm/solver/state.inl). AlphaMinusJacobian applies αI using a row-aware identity mask, preparing for masked constraint rows (include/micm/solver/rosenbrock.inl). Tests: cmake --build build and ctest --output-on-failure (all 48 tests passed).

davidfillmore and others added 12 commits October 15, 2025 11:11
@davidfillmore
Added StateParameters.number_of_constraints.
48a719c
@davidfillmore
Added number_of_constraints to solver_builder.inl.
1f10bba
@davidfillmore
Added number_of_constraints arguments to AbstractBackwardEuler.
8acd5c9
@davidfillmore
Use number_of_species + number_of_constraints in BuildJacobian.
30971c2
@davidfillmore
Added upper_left_diagonal_elements_.
2117432
@davidfillmore
Added upper_left_diagonal_elements_ in State constructors.
51f7e27
@davidfillmore
Added constraint_size_ to State.
cd249cc
@davidfillmore
Renamed to upper_left_identity_diagonal_.
98d15be
@davidfillmore
BuildJacobian with state_size_ + constraint_size_ in State.
767addb
Added includes.
255d3c7
Merge branch 'main' into rosenbrock_dae
c2df336
Implemented builder-level support for future constraints without chan…
5c3e587 
…ging current behavior: added constraint count/name setters and used them to size Jacobian/state vectors and extend variable names, while carrying the count into StateParameters (include/micm/solver/solver_builder.hpp, include/micm/solver/solver_builder.inl). State now honors the provided constraint count when building identity masks and Jacobian dimensions (include/micm/solver/state.inl). AlphaMinusJacobian applies αI using a row-aware identity mask, preparing for masked constraint rows (include/micm/solver/rosenbrock.inl). Tests: cmake --build build and ctest --output-on-failure (all 48 tests passed).
@davidfillmore davidfillmore changed the title rosenbrock dae Rosenbrock DAE Constraint Count Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidfillmore