-
Notifications
You must be signed in to change notification settings - Fork 23
Zarr write + Zarr groups #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Not a very large PR, this one! I don't know what to do about the recipe files linting thing ... |
As for reverting the recipes linter/isort auto-changes as discussed in-person, the git command I mentioned that is simplest would be |
|
I'll start reviewing now ignoring the linting changes to the recipes... |
sadielbartholomew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, with tests all passing and relevant packaging, docs and tests updates for the new Zarr read and write funcionality - though ideally drop the recipes linting auto-changes as discussed in person (see my comment above for recommended command to revert).
| {{read group_dimension_search: `str`, optional}} | ||
| .. versionadded:: (cfdm) NEXTVERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .. versionadded:: (cfdm) NEXTVERSION | |
| .. versionadded:: NEXTVERSION |
| * create new field constructs in memory, | ||
| * write and append field constructs to netCDF datasets on disk, | ||
| * write and append field constructs and domain to netCDF and Zarr v3 datasets on disk, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * write and append field constructs and domain to netCDF and Zarr v3 datasets on disk, | |
| * write and append field and domain constructs to netCDF and Zarr v3 datasets on disk, |
| * Write Zarr v3 datasets with `cf.write`, and allow the reading of | ||
| grouped Zarr v2 and v3 datasets with `cf.read` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Write Zarr v3 datasets with `cf.write`, and allow the reading of | |
| grouped Zarr v2 and v3 datasets with `cf.read` | |
| * Write Zarr v3 datasets with `cf.write` |
since the second part is duplicating the information in the bullet below (and I think it is nice to have them as separate bullets given the separate linked Issues).
|
|
||
| * set the output netCDF format (all netCDF3 and netCDF4 formats are | ||
| possible); | ||
| * set the output netCDF format (all netCDF3 and netCDF4 formats, as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * set the output netCDF format (all netCDF3 and netCDF4 formats, as | |
| * set the output format (all netCDF3 and netCDF4 formats, as |
seems better since Zarr isn't really netCDF.
|
Thanks for the git command. I did |
Fixes #894 and #895