Skip to content

Prevent read error for datasets including badly-encoded UGRID meshes #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadielbartholomew merged 4 commits into from
Jan 29, 2025
Merged

Prevent read error for datasets including badly-encoded UGRID meshes #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6569aac
Prevent UnboundLocalError in read from UGRID mesh report
sadielbartholomew Jan 13, 2025
fac532c
Update Changelog for PR to close #315
sadielbartholomew Jan 13, 2025
409a40f
Merge branch 'main' into ugrid-read
sadielbartholomew Jan 17, 2025
f89726e
Update netcdfread.py to remove duplicate import
sadielbartholomew Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ Version NEXTVERSION
* Fix bug that caused `cfdm.write` to fail when a parametric Z
dimension coordinate did not have a ``computed_standard_name``
attribute (https://github.com/NCAS-CMS/cfdm/issues/303)
* Fix bug that caused `cfdm.read` to fail to read at all
datasets including variables with badly-encoded UGRID meshes
(https://github.com/NCAS-CMS/cfdm/issues/315)
* New class `cfdm.H5netcdfArray`
* New class `cfdm.NetCDF4Array`
* Changed dependency: ``numpy>=1.15,<2.0``
Expand Down
6 changes: 4 additions & 2 deletions cfdm/read_write/netcdf/netcdfread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from copy import deepcopy
from dataclasses import dataclass, field
from functools import reduce
from pprint import pformat
from math import log, nan, prod
from numbers import Integral
from typing import Any
Expand Down Expand Up @@ -3820,9 +3821,10 @@ def _create_field_or_domain(
ugrid = False
logger.warning(
"There was a problem parsing the UGRID mesh "
f"topology variable {mesh.mesh_ncvar!r}: "
f"Ignoring the UGRID mesh for {field_ncvar!r}."
"topology variable. Ignoring the UGRID mesh "
f"for {field_ncvar!r}."
)
logger.debug(f"Mesh dictionary is: {pformat(g['mesh'])}")

if ugrid:
# The UGRID specification is OK, so get the auxiliary
Expand Down