Skip to content

Add distributed as required dependency with version pin #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadielbartholomew merged 5 commits into from
Jul 25, 2025
Merged

Add distributed as required dependency with version pin #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0cfea70
Add distributed pin on v.2025.5.1 to requirements
sadielbartholomew Jul 21, 2025
2ae692b
Add check for suitable importable distributed module
sadielbartholomew Jul 21, 2025
5c68ce8
Update cfdm.environment output to include distributed version
sadielbartholomew Jul 21, 2025
0ebff03
Docs: add distrbiuted to installation page requires list
sadielbartholomew Jul 21, 2025
30bdfb5
Update changelog for new dependency
sadielbartholomew Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
Version NEXTVERSION
--------------

**2025-??-??**

* New dependency: ``distributed>=2025.5.1``

----

Version 1.12.2.0
----------------

Expand Down
14 changes: 14 additions & 0 deletions cfdm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,20 @@
f"Got {dask.__version__} at {dask.__file__}"
)

# Check the version of distributed
try:
import distributed
except ImportError as error1:
raise ImportError(_error0 + str(error1))
else:
_minimum_vn = "2025.5.1"
if Version(distributed.__version__) < Version(_minimum_vn):
raise ValueError(
"Bad distributed version: cfdm requires "
f"distributed>={_minimum_vn}. "
f"Got {distributed.__version__} at {distributed.__file__}"
)

# Check the version of uritools
try:
import uritools
Expand Down
2 changes: 2 additions & 0 deletions cfdm/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ def environment(display=True, paths=True):
s3fs: 2024.12.0
scipy: 1.15.1
dask: 2025.5.1
distributed: 2025.5.1
cftime: 1.6.4.post1
cfunits: 3.3.7
cfdm: 1.12.2.0
Expand All @@ -452,6 +453,7 @@ def environment(display=True, paths=True):
"s3fs": _get_module_info("s3fs"),
"scipy": _get_module_info("scipy"),
"dask": _get_module_info("dask"),
"distributed": _get_module_info("distributed"),
"cftime": _get_module_info("cftime"),
"cfunits": _get_module_info("cfunits"),
"cfdm": (__version__, os.path.abspath(__file__)),
Expand Down
5 changes: 4 additions & 1 deletion docs/source/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,10 @@ The cfdm package requires:

* `s3fs <https://pypi.org/project/s3fs>`_, version 2024.6.0 or newer.

* `dask <https://pypi.org/project/dask>`_, versions 2025.5.1 or newer.
* `dask <https://pypi.org/project/dask>`_, version 2025.5.1 or newer.

* `distributed <https://pypi.org/project/distributed>`_, version 2025.5.1
or newer.

* `packaging <https://pypi.org/project/packaging>`_, version 20.0 or
newer.
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ h5netcdf>=1.3.0
h5py>=3.12.0
s3fs>=2024.6.0
dask>=2025.5.1
distributed>=2025.5.1
uritools>=4.0.3
cfunits>=3.3.7
zarr>=3.0.8
Loading