Redesigned dataset_compliance w/ standard names validation
#373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
added
enhancement
sadielbartholomew
changed the title
dataset_compliance output with POC of standard names validationdataset_compliance w/ POC of standard names validation
sadielbartholomew
changed the title
dataset_compliance w/ POC of standard names validationdataset_compliance w/ standard names validation
sadielbartholomew
force-pushed
the
validate-standard-names
branch
from
e241532 to
73e8d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #366 by setting up discussed data structure to close #365, reporting invalid standard names in the new output structure, as indicated in #365 (comment).
Opening as a draft since it's my last working day before the Christmas break but I have a few issues left to iron out (I only realised today a few bad standard names weren't being reported and yet to diagnose the reason why - annoying timing but I need to call it a day at some point!). In Jan when I am back to work I will finalise and add some notes to aid reviewing here.