Skip to content

Conversation

@davidhassell
Copy link
Collaborator

@davidhassell davidhassell requested a review from bnlawrence April 25, 2025 16:03
raise AttributeError

order_dim = self._parent._cached_order_dim
except AttributeError:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is going on. If you have a try with a raise attributerror and an except attributerror around it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the raise AttributeError happens, it jumps us to the except AttributeError: block, just as if a line of code had resulted in an AttributeError being raised.

@davidhassell
Copy link
Collaborator Author

Hi @bnlawrence - can we merge this, prior to making our PR the upstream h5netcdf? Ta

@davidhassell
Copy link
Collaborator Author

Hang on - I've noticed that this branch creates a failure in one of the h5netcdf unit tests (I presume the I overlooked this earlier, thinking that all the failures were the ones we expect and see on the main branch of h5netcdf).

I'm investigating. My initial thoughts are that if this is gnarly, we simply remove this PR from the final PR to upstream h5netcdf, especially because it is only a partial solution to the problem, and has comments in it along the lines of "I don't understand this, so I'm going to ...". Let's see it it's a simple fix ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants