-
Notifications
You must be signed in to change notification settings - Fork 25
Add support for pre-commit with mypy and Ruff and start adding type hints #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
valeriupredoi
wants to merge
21
commits into
main
Choose a base branch
from
add_typehints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 76.83% 76.83%
=======================================
Files 15 15
Lines 2936 2936
Branches 467 467
=======================================
Hits 2256 2256
Misses 558 558
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OK @bnlawrence @davidhassell I have added full infrastructure for pre-commit with ruff and mypy (though I have turned off mypy temporarily, while we fix or exclude ruff barfs, then I can turn it back on and we'll have to fix the type hints). Because the code is a mix of (very) old code, code that's been written with functionality in mind, and decent standards code, we have Ruff complaining about a lot of things - some of them are already fixed via a
pre-commit run -a, some need attention but are easy fixes, and some are really tricky to fix; how do you propose we do the work? For now pre-commit doesn't run ontests/nor ondoc/- I'll have to turn on running ontests/at some point in the future, but let's focus on the main source code for now.To run pre-commit, check out this branch, make sure you have pre-commit installed (from conda-forge) then:
Before you get started
Checklist