Support our own notifications#398
Draft
Megha-Dev-19 wants to merge 1 commit intoNEARBuilders:developfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
I like the idea of creating new indices, and I think I could get behind the structure with some more reasoning -- If I were to How might we define a "Notification" type? but maybe we can continue this discussion through notify.near on gateway? Can you create this project pointing to "notify.near" account? |
Collaborator
Author
|
I have moved this conversation here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #293
Instead of using custom notifications, which is supported on near.org (but contains quite a few bugs) and isn't supported on near.social, I thought of adding our own index like
buildhub.near/{{feature}}/{{action}}.Because now we have our own notifications page in gateway, where we can easily support it.
Eg: for proposal, it will be
buildhub.near/proposal/vote,buildhub.near/proposal/create, similarly we can have it for events, and other features. We can have "Approve", "Reject", "View", all these different actions for different type of feature and actions.@elliotBraem what do you think of the idea and structure? if you agree, I will continue to add further changes to the PR