Conversation
Merge branch 'master' into suna # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Merge branch 'master' into suna # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Merge branch 'master' into suna # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Merge branch 'master' into suna # Conflicts: # pipe/sunav2/sunav2_calibration_assignment.json # pipe/sunav2/sunav2_location_active_dates_assignment.json # pipe/sunav2/sunav2_location_asset_assignment.json # pipe/sunav2/sunav2_merge_data_by_location.json # pipe/sunav2/sunav2_structure_repo_by_location.json
Merge branch 'master' into suna # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Reverting minor change from master
bring base image to current
bring base image to current
bring base image to current
bring base image to current
bring qaqc image to current
bring base image to current
bring cal image to current
bring image to current
bring image to current
covesturtevant
requested changes
Jan 26, 2026
Contributor
covesturtevant
left a comment
covesturtevant
left a comment
There was a problem hiding this comment.
Overall looks great. A few moderate bits of work to address, but I don't think they'll be too much work. Please also create unit tests for new modules. Recommend feeding Copilot one of our unit tests as a template and asking it to create the ones for the new modules.
Please let me know if any comments could use clarification.
Contributor
There was a problem hiding this comment.
Note for Cove to merge in the kafka loader to the main DAG
Merge branch 'master' into suna # Conflicts: # pipe/sunav2/pipe_list_sunav2.txt # pipe/sunav2/site-list.json # pipe/sunav2/sunav2_cron_daily_and_date_control.yaml # pipe/sunav2/sunav2_data_source_kafka.yaml
Contributor
Author
|
@covesturtevant all comments have been addressed and unit tests created for all new modules. Thanks for the close review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.