Conversation
… fix bug in warning message by_tile_aop, update year validation, use API to determine active AOP products
Collaborator
|
@bhass-neon Thanks Bridget! A couple of tweaks on the DPID validation:
|
Collaborator
Author
|
@cklunch - thanks for the review. I updated the documentation for the get_aop_dpids and validate_aop_l3_dpid functions. For the foliar spectra product (DP1.30012.001), not sure where you think there should be an exception? I left the check_field_spectra_dpid validation check in, but since this DPID doesn't start with DP3 and is not DP1.30003.001, I don't think an exception is needed in the validate_aop_l3_dpid function. Let me know if you were thinking of something else. |
Collaborator
Author
|
Fixed get_aop_dpids documentation - I missed the AOP part before ... |
Collaborator
|
@bhass-neon Got it, thanks! I think we're good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to address issues raised in #20 + update validate_year function to set valid dates from 2012 to the current year, as per a PyOpenSci suggestion. Major updates include:
Additional tests for AOP L3 camera (DP3.30010.001) and tiled point cloud (DP1.30003.001) data products will be added in the integration tests in the nu-python-testing repository: https://github.com/NEONScience/nu-python-testing/blob/main/tests/integration/test_aop_download.py.