Sound broadcaster #76
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt to add sound. Maybe I don't understand the whole problem, but I came up with this, and I would love some feedback.
I created a broadcaster for sounds and a demo to showcase how to use it. As part of the broadcaster, I created a
BroadcastMessagedata type. If you like that idea, I will convert the MQTT broadcaster to the same data type. Another design decision I made is that all messages sent through the broadcast queue are copied to all broadcasters. This allows the broadcaster to decide if it wants to deal with the message or not. For example, I expected the sound broadcaster to only care about SOUND broadcasts. However, the MQTT broadcaster might care about SOUNDS and TEXT broadcasts.We also might want to create a
ControllerMessagedata type, but that is for another pull request.