-
Notifications
You must be signed in to change notification settings - Fork 1
Pygame dependency fix #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
christopolise
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great for the most part, however when I run
python3 main.py -vvv simulator I get an error saying that I needed to provide a value for simulated
Traceback (most recent call last):
File "/home/christopolise/dev/sss/main.py", line 104, in <module>
cli()
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
return self.main(*args, **kwargs)
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/christopolise/dev/sss/venv/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/home/christopolise/dev/sss/main.py", line 30, in run_simulator
simulator.run()
File "/home/christopolise/dev/sss/runners/simulator.py", line 366, in run
sim.start()
File "/home/christopolise/dev/sss/runners/simulator.py", line 310, in start
handle_input = controllers.start_inputs(self.system_q, self.input_q)
TypeError: start_inputs() missing 1 required positional argument: 'simulated'
When checking the help messages, I find no mention of changes of command line args for running things in a simulated environment, so maybe include some of those if we are changing the way we run things?
|
@apal6981, can you rebase this PR so that the changes that were previously accepted don’t show up in this PR (physical_screen2.py, etc.)? |
… were breaking windows
|
I believe i have addressed the issues that needed to be addressed. I might have botched the rebase so somebody might want to look at that. I got a bit lost trying to do it on the commandline. |
2972705 to
06304e3
Compare
I was bothered that pygame was being imported by default. I changed that it only gets loaded when the screen is being simulated. The keyboard broadcaster was the culprit. I changed it that the keyboard is only checked when the virtual screen is being used. Also stuff from v2 merge so lets confirm and pull that one before this one.