Use only log files #89
Conversation
No longer print log messages to stderr
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes logger configuration from runners/kiosk.py to main.py and switches from dual logging (stderr + file) to file-only logging.
- Moved logger configuration from kiosk-specific runner to the main CLI entry point
- Changed from stderr output to exclusively file-based logging at
logs/sss.log - Applied consistent logging configuration across all CLI commands (simulator, kiosk, demo, test)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| main.py | Added centralized logger configuration with file-only output, removed stderr logging |
| runners/kiosk.py | Removed redundant logger configuration and startup banner that is now handled centrally |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| level=logger_level[verbose], | ||
| ) | ||
|
|
||
| logger.info(" ____") | ||
| logger.info(" / . .\\") | ||
| logger.info(" \\ ---< Starting SSS") | ||
| logger.info(" \\ /") | ||
| logger.info(" __________/ /") | ||
| logger.info("-=:___________/") |
There was a problem hiding this comment.
With the default verbosity level (verbose=0), the logger level is set to "ERROR", which means these INFO level messages (including the ASCII art banner) won't be logged. Users would need to pass -vvv to see INFO messages or -vvvv for DEBUG messages. Consider setting a more appropriate default logging level (e.g., INFO) or documenting this behavior, as many important operational messages throughout the codebase use logger.info() and logger.debug().
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
No longer print log messages to stderr