Add display configuration #95
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How did it get on the branch if it isn't formatted correctly?!?
Member
Author
|
If this PR does go through, I think it would be worth consolidating configuration files. There is also an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to set a display configuration. It is a 2D array of IP addresses in a JSON file. This will make it easier to run the single-display SSS without changing the source code.
@christopolise, what do you think? Since this is only for the new hardware, I based this on the newHardwareFirmware branch since it hasn't been merged into dev, yet, right?
This is a draft pull request because I would like the
example_config.jsonfile to reflect the actual configuration for the main SSS, which I haven't done yet.