Open
Conversation
Mirazyzz
reviewed
Sep 23, 2023
Comment on lines
+94
to
+96
| .Where(x => predicate(x)) | ||
| .ToList() | ||
| .Count; |
Contributor
There was a problem hiding this comment.
Where()
.ToList()
.Count
o'rniga
Count(x => predicate(x))
qilsa bo'ladi, bu tarzda ko'd ihchamroq va keraksiz kontekstdan xalos bo'ladi.
Mirazyzz
reviewed
Sep 23, 2023
| } | ||
|
|
||
| static void ExecuteOperation(int a, int b, Func<int, int, int> func, Action<int> display) | ||
| static int Max(int[] array, Predicate<int>predicate) |
Contributor
There was a problem hiding this comment.
predicate o'zgaruvchanini e'lon qilishdan oldin bitta bo'shliq qoldirish kerak, barchasi bir narsadek tuyilmasligi uchun. Sababi Predicate bu o'zgaruvchanni toifasi, predicate esa o'zgaruvchanni (parameterni) nomi.
Mirazyzz
reviewed
Sep 23, 2023
| static decimal[] Convert(decimal[] array, Func<decimal, decimal> converter) | ||
| { | ||
| return a - b; | ||
| List<decimal> list = new List<decimal>(); |
Contributor
There was a problem hiding this comment.
decimal[] arrayni e'lon qilib shu massivga elementlarni qo'shib ketilsa, keraksiz List e'lon qilinmaydi hamda xotiradan joy olinmaydi.
Mirazyzz
approved these changes
Sep 23, 2023
Contributor
Mirazyzz
left a comment
Mirazyzz
left a comment
There was a problem hiding this comment.
Kichik kamchiliklar bor. Umuman olganda, yaxshi. 5dan 4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.