Skip to content

Use --no-alerts-state in PartialCheckResult #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use --no-alerts-state in PartialCheckResult #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/alert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ inactive = 0`,
// When there are no alerts we add an empty PartialResult just to have consistent output
if len(overall.PartialResults) == 0 {
sc := result.NewPartialResult()
// We already make sure it's valid
//nolint: errcheck
sc.SetDefaultState(noAlertsState)
sc.Output = "No alerts retrieved"
overall.AddSubcheck(sc)
}
Expand Down
4 changes: 2 additions & 2 deletions cmd/alert_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ exit status 2
w.WriteHeader(http.StatusOK)
w.Write(loadTestdata(alertTestDataSet2))
})),
args: []string{"run", "../main.go", "alert", "--name", "NoSuchAlert"},
args: []string{"run", "../main.go", "alert", "--name", "NoSuchAlert", "-T", "3"},
expected: `[UNKNOWN] - 0 Alerts: 0 Firing - 0 Pending - 0 Inactive
\_ [UNKNOWN] No alerts retrieved
|total=0 firing=0 pending=0 inactive=0
Expand All @@ -179,7 +179,7 @@ exit status 3
w.WriteHeader(http.StatusOK)
w.Write(loadTestdata(alertTestDataSet2))
})),
args: []string{"run", "../main.go", "alert", "--name", "InactiveAlert", "--problems"},
args: []string{"run", "../main.go", "alert", "--name", "InactiveAlert", "--problems", "-T", "3"},
expected: `[UNKNOWN] - 0 Alerts: 0 Firing - 0 Pending - 0 Inactive
\_ [UNKNOWN] No alerts retrieved
|total=0 firing=0 pending=0 inactive=0
Expand Down