feat(loop): modern-monaco - アプリテーマ連動Monaco4テーマ実装#10
Draft
NEXT-STANDARD wants to merge 3 commits intomainfrom
Draft
feat(loop): modern-monaco - アプリテーマ連動Monaco4テーマ実装#10NEXT-STANDARD wants to merge 3 commits intomainfrom
NEXT-STANDARD wants to merge 3 commits intomainfrom
Conversation
Register SF_MONACO_THEMES (cyan/magenta/green/gold) and apply the correct theme based on the active app theme variant. Theme switches dynamically via useEffect when the user changes the color scheme in settings. Cycle score: 10/10 (delta: +4) Co-Authored-By: SF Editor Improvement Loop <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SF_MONACO_THEMESマップ（cyan/magenta/green/gold）を定義し、アプリのカラーテーマに対応した4種類のMonacoエディタテーマを登録SFEditorにactiveThemeプロップを追加し、設定変更時にリアルタイムでMonacoテーマを切り替えるuseEffectを実装AppContentからapp.settings.themeをSFEditorに渡すよう修正Test plan
vite build+tsc -p electron/tsconfig.json）Cycle 25 Score
10/10 (delta: +4)
Generated by Claude Code