Skip to content

add domain namespace to cache check if statement#82

Merged
dylanlee merged 1 commit intomainfrom
fix_parameter_metadata_caching
Apr 15, 2026
Merged

add domain namespace to cache check if statement#82
dylanlee merged 1 commit intomainfrom
fix_parameter_metadata_caching

Conversation

@danielcumpton
Copy link
Copy Markdown

[Short description explaining the high-level reason for the pull request]

Additions

Change if statement that checks for a cached version of the iceberg tables to check for the domain namespace in addition to the parameter_metadata namespace. Both namespaces need to be available in the cache to run the parameter_metadata endpoint, otherwise the glue catalog needs to be used.

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@danielcumpton danielcumpton requested a review from dylanlee April 14, 2026 16:10
@danielcumpton danielcumpton self-assigned this Apr 14, 2026
Copy link
Copy Markdown

@dylanlee dylanlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@dylanlee dylanlee merged commit 8ec797e into main Apr 15, 2026
9 checks passed
@dylanlee dylanlee deleted the fix_parameter_metadata_caching branch April 15, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants