Skip to content

Gates initial geometa dimensionality check by discretization. #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyle-larkin wants to merge 1 commit into
base: development
Choose a base branch
from
+11 −6
Open

Gates initial geometa dimensionality check by discretization. #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions NextGen_Forcings_Engine_BMI/NextGen_Forcings_Engine/bmi_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,15 +783,20 @@ def initialize(self, config_file: str, output_path: str | None = None) -> None:
err_handler.err_out_screen_para(self._job_meta.errMsg, self._mpi_meta)
err_handler.check_program_status(self._job_meta, self._mpi_meta)

# Check to make sure we have enough dimensionality to run regridding. ESMF requires both grids
# to have a size of at least 2.
# Check to make sure we have enough dimensionality to run regridding. We assume that hydrofabric discretizations are large
# enough that 1x1 (single catchment) will provide enough points. For gridded and unstructured domains, we need to make sure
# that the local grid size for each processor is at least 2x2 to run the regridding process.
# forcing_input dimensionality is checked in regrid.py.

dimensionality = 1 if self._grid_type == "hydrofabric" else 2

if (
self._wrf_hydro_geo_meta.nx_local < 2
or self._wrf_hydro_geo_meta.ny_local < 2
self._wrf_hydro_geo_meta.nx_local < dimensionality
or self._wrf_hydro_geo_meta.ny_local < dimensionality
):
self._job_meta.errMsg = (
"You have specified too many cores for your WRF-Hydro grid. "
"Local grid Must have x/y dimension size of 2."
f"You have specified too many cores for your WRF-Hydro grid. "
f"Local grid Must have x/y dimension size of {dimensionality}."
)
err_handler.err_out_screen_para(self._job_meta.errMsg, self._mpi_meta)
err_handler.check_program_status(self._job_meta, self._mpi_meta)
Expand Down
Loading