Skip to content

Jwade ngwpc 9542 hyfab esmf nhf#136

Open
jswade-rtx wants to merge 2 commits intodevelopmentfrom
jwade_NGWPC-9542_hyfab_esmf_nhf
Open

Jwade ngwpc 9542 hyfab esmf nhf#136
jswade-rtx wants to merge 2 commits intodevelopmentfrom
jwade_NGWPC-9542_hyfab_esmf_nhf

Conversation

@jswade-rtx
Copy link
Copy Markdown

Updates the NextGen Hydrofabric to ESMF mesh conversion script to support the NHF hydrofabric geopackage format, eliminated the need for an external parquet file for the hydrofabric model attributes.

Additions

Removals

Changes

  • NextGen_hyfab_to_ESMF_Mesh.py - Updated catchment ID reading to use div_id instead of the HF2.2 id column from the divides layer. Removed optional parquet file dependency by reading elevation, slope, and aspect attributes direction from the NHF divides layer. Removed -parquet CLI argument.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@jswade-rtx jswade-rtx force-pushed the jwade_NGWPC-9542_hyfab_esmf_nhf branch from bc06736 to 9ef18e2 Compare April 17, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant